Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trace-core: Augment Subscriber::record_follows_from docs #81

Closed
LucioFranco opened this issue Mar 14, 2019 · 2 comments
Closed

trace-core: Augment Subscriber::record_follows_from docs #81

LucioFranco opened this issue Mar 14, 2019 · 2 comments
Assignees
@hawkw
Labels
crate/core Related to the `tracing-core` crate kind/docs
Milestone
tracing 0.1

Comments

@LucioFranco
Copy link
Member

Currently, reading the Subscriber::record_follows_from are extensive but lacks information of when this might be called. There exists the api in tokio-trace it self for a span to follow from another but this does not exist in tokio-trace-core and this to me is an area that could generate some confusion.
@LucioFranco
Copy link
Member Author

cc @hawkw

@hawkw hawkw self-assigned this May 7, 2019
hawkw referenced this issue in tokio-rs/tokio Jun 13, 2019
@hawkw
trace: Document span follows-from relationships
9525084 
Fixes #985

Signed-off-by: Eliza Weisman <[email protected]>
@carllerche carllerche transferred this issue from tokio-rs/tokio Jun 24, 2019
@hawkw hawkw added crate/core Related to the `tracing-core` crate kind/docs labels Jun 24, 2019
@hawkw hawkw modified the milestones: tracing-core 0.1, tracing 0.1 Jun 26, 2019
@hawkw
Copy link
Member

hawkw commented Jun 28, 2019

This was fixed in d1a6eff

@hawkw hawkw closed this as completed Jun 28, 2019
@rklaehn rklaehn mentioned this issue Jan 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hawkw hawkw

Labels
crate/core Related to the `tracing-core` crate kind/docs
Projects
None yet
Milestone
tracing 0.1
Development

No branches or pull requests
2 participants
@hawkw @LucioFranco