You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When tracing-opentelemetry reports events to opentelemetry, it sets the target property to the target of the tracing::Event. This same functionality should be extended to tracing::Span data to make it more obvious where spans are coming from.
Here is a screenshot of a trace from tracing-opentelemetry viewed in Jager. Many crates have very simple span names, which can make it difficult to discern where they are coming from without the additional context of the target attribute.
Proposal
I think it should be added in the same way as the target is added to the event data, at the time we build the opentelemetry span. Possible downsides are storing extra data or making additional allocations when they could be avoided.
Alternatives
This could possibly be an opt-in behavior set by consumers of the crate when they construct the subscriber.
The text was updated successfully, but these errors were encountered:
Feature Request
Crates
tracing-opentelemetry
Motivation
When tracing-opentelemetry reports events to opentelemetry, it sets the
target
property to the target of thetracing::Event
. This same functionality should be extended totracing::Span
data to make it more obvious where spans are coming from.tracing/tracing-opentelemetry/src/subscriber.rs
Line 533 in b6c07e7
Here is a screenshot of a trace from tracing-opentelemetry viewed in Jager. Many crates have very simple span names, which can make it difficult to discern where they are coming from without the additional context of the
target
attribute.Proposal
I think it should be added in the same way as the
target
is added to the event data, at the time we build the opentelemetry span. Possible downsides are storing extra data or making additional allocations when they could be avoided.Alternatives
This could possibly be an opt-in behavior set by consumers of the crate when they construct the subscriber.
The text was updated successfully, but these errors were encountered: