Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deprecated Error::cause #818

Merged
merged 1 commit into from
Jan 2, 2019
Merged

Allow deprecated Error::cause #818

merged 1 commit into from
Jan 2, 2019

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Dec 29, 2018

Motivation

#817

Error::cause is deprecated in Rust 1.33, but Error::source, which replaces it, has been stabilized in Rust 1.30 (the minimum version of tokio is Rust 1.26)..

Solution

Allow Error::cause until the minimum supported version of tokio is Rust 1.30.

When the minimum support version of tokio reaches Rust 1.30, replace Error::cause with Error::source.

Error::cause is deprecated in Rust 1.33, but this allows Error::cause
until the minimum supported version of tokio is Rust 1.30.

When the minimum support version of tokio reaches Rust 1.30,
replace Error::cause with Error::source.

Fixes: #817
@taiki-e
Copy link
Member Author

taiki-e commented Dec 29, 2018

This makes the nightly build succeed.

Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@carllerche carllerche merged commit 9a8d087 into tokio-rs:master Jan 2, 2019
@taiki-e taiki-e deleted the error-cause branch January 4, 2019 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants