Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use #[non_exhaustive] instead of private unit field #3320

Merged
merged 1 commit into from
Dec 23, 2020
Merged

chore: use #[non_exhaustive] instead of private unit field #3320

merged 1 commit into from
Dec 23, 2020

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Dec 23, 2020

#[non_exhaustive] is the official feature for this pattern and was stable at Rust 1.40.

Darksonn
Darksonn approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@taiki-e taiki-e merged commit 575938d into tokio-rs:master Dec 23, 2020
@taiki-e taiki-e deleted the non-exhaustive branch December 23, 2020 13:48
@taiki-e taiki-e mentioned this pull request Dec 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

@carllerche carllerche Awaiting requested review from carllerche

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taiki-e @Darksonn