-
Notifications
You must be signed in to change notification settings - Fork 82
Clarify In/Out terminology #64
Comments
FWIW, in hyper I have the concept of Incoming vs Outgoing. This distinction appears in other HTTP libraries that I've looked at. This causes a very odd-looking case: impl<T> FramedIo for Conn<T> {
type In = T::Outgoing;
type Out = T::Incoming;
// ...
} |
In my terminology, In = message going into the socket, Out = "message coming out of the socket" What is incoming / outgoing in your case? |
Incoming = message incoming to this machine, Outgoing = message going out from this machine. |
This is confusing every time for me. I don't think inverting the in/out cases would make it any more intuitive. |
Usually seen as the second choice: Read in a request, write out a response. I think it would be very confusing the other way around. This matches Finagle Service definitions Finagle Services as well as Wangle (and pretty much any socket library I've worked with for what it's worth). What I don't see or haven't wrapped my head around is the filters part of Framing for tokio. I know I've gone back and forth with @carllerche on this in #63 and gitter but embedding the types that way seems rather limiting and requires lots of boilerplate and manual plumbing. |
There is no more In / Out. |
There is in |
@tikue sure yeah, I've opened one: tokio-rs/tokio-core#135 |
Commented here: #62 (comment)
I personally interpret in/out with one of two interpretations:
Unfortunately these mean opposite things :(. Looks like this is standard terminology in finagle though? (cc #62 (comment)). Maybe I should just shift how I view these?
(may also be worth exploring alternative names)
The text was updated successfully, but these errors were encountered: