Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: surface WatchDetails errors in the UI #253

Open
hawkw opened this issue Jan 7, 2022 · 1 comment
Open

console: surface WatchDetails errors in the UI #253

hawkw opened this issue Jan 7, 2022 · 1 comment
Labels
C-console Crate: console. S-feature Severity: feature. This is adding a new feature.

Comments

@hawkw
Copy link
Member

hawkw commented Jan 7, 2022

A follow-up that I didn't address in this branch, but that we probably ought to add, is something that's displayed in the UI when we can't get details for a task. Currently, when a watch_details RPC returns an error, we log it...but logs from the console aren't visible in the UI and can only be viewed if the user redirects them to a file. So, we probably want to add something in the UI showing that there was an error.

Originally posted by @hawkw in #251 (comment)
@hawkw
Copy link
Member Author

hawkw commented Jan 7, 2022 •
edited
Loading

We may want to consider a fully-featured system for displaying non-fatal console internal errors in the UI. Perhaps this could piggyback on the warnings system? It would be nice to use a different icon/symbol to differentiate internal console errors from warnings about the application...

@hawkw hawkw added S-feature Severity: feature. This is adding a new feature. C-console Crate: console. labels Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-console Crate: console. S-feature Severity: feature. This is adding a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hawkw