You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The recording features in console-subscriber requires additional dependencies (e.g. serde-json) that we don't need anywhere else in the console. My PR #238 will probably also add a crossbeam-channel dependency to the recording code. It would be kind of nice if the recording feature was feature-flagged so that these dependencies can be disabled by users who aren't using recordings.
The one potential concern about feature flagging this is that it could be considered a breaking change. However, feature-flagging it wouldn't make any APIs disappear, just behavior. Should this be considered a semver-breaking change?
The text was updated successfully, but these errors were encountered:
The recording features in
console-subscriber
requires additional dependencies (e.g.serde-json
) that we don't need anywhere else in the console. My PR #238 will probably also add acrossbeam-channel
dependency to the recording code. It would be kind of nice if the recording feature was feature-flagged so that these dependencies can be disabled by users who aren't using recordings.The one potential concern about feature flagging this is that it could be considered a breaking change. However, feature-flagging it wouldn't make any APIs disappear, just behavior. Should this be considered a semver-breaking change?
The text was updated successfully, but these errors were encountered: