Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscriber: feature-flag recording #245

Open
hawkw opened this issue Dec 28, 2021 · 1 comment
Open

subscriber: feature-flag recording #245

hawkw opened this issue Dec 28, 2021 · 1 comment
Assignees
Labels
C-subscriber Crate: console-subscriber.

Comments

@hawkw
Copy link
Member

hawkw commented Dec 28, 2021

The recording features in console-subscriber requires additional dependencies (e.g. serde-json) that we don't need anywhere else in the console. My PR #238 will probably also add a crossbeam-channel dependency to the recording code. It would be kind of nice if the recording feature was feature-flagged so that these dependencies can be disabled by users who aren't using recordings.

The one potential concern about feature flagging this is that it could be considered a breaking change. However, feature-flagging it wouldn't make any APIs disappear, just behavior. Should this be considered a semver-breaking change?

@hawkw hawkw added the C-subscriber Crate: console-subscriber. label Dec 28, 2021
@hawkw hawkw self-assigned this Dec 28, 2021
@hawkw
Copy link
Member Author

hawkw commented Dec 28, 2021

cc @seanmonstar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-subscriber Crate: console-subscriber.
Projects
None yet
Development

No branches or pull requests

1 participant