Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytes::with_vtable Can it be opened for external use #526

Closed
xiaxiangjun opened this issue Jan 10, 2022 · 4 comments
Closed

Bytes::with_vtable Can it be opened for external use #526

xiaxiangjun opened this issue Jan 10, 2022 · 4 comments

Comments

@xiaxiangjun
Copy link

xiaxiangjun commented Jan 10, 2022

Just want to use it to use shared memory, but it pub(crate) unsafe fn with_vtable and pub(crate) struct Vtable, Hope to change to remote (crate)

@xiaxiangjun
Copy link
Author

path: src/bytes.rs:102

pub(crate) struct Vtable
// Change to
pub struct Vtable

path: src/bytes.rs:478

pub(crate) unsafe fn with_vtable
// Change to
pub unsafe fn with_vtable

path: src/lib.rs:92

// add
pub use crate::bytes::Vtable;

@NobodyXu
Copy link
Contributor

Why not open a PR then?

@seanmonstar
Copy link
Member

It is an eventual goal to make it public, but there are unresolved questions around forwards-compatibility.

  • Is the current vtable all the functions that are needed?
  • If we identify a new function later, how can we add it to the vtable without breaking people?

@Darksonn
Copy link
Contributor

Closing as duplicate of #437.

@Darksonn Darksonn closed this as not planned Won't fix, can't repro, duplicate, stale Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants