Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample Array from Float Curve #510

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Sample Array from Float Curve #510

merged 2 commits into from
Nov 12, 2024

Conversation

mck
Copy link
Collaborator

@mck mck commented Nov 11, 2024

This node lets you sample multiple points on a float curve and outputs them in a number array.

@mck mck requested a review from SorsOps November 11, 2024 16:10
Copy link

changeset-bot bot commented Nov 11, 2024

🦋 Changeset detected

Latest commit: d0dabf7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@tokens-studio/graph-engine Minor
@tokens-studio/graph-engine-nodes-audio Major
@tokens-studio/graph-engine-nodes-design-tokens Major
@tokens-studio/graph-engine-nodes-fs Major
@tokens-studio/graph-engine-nodes-image Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Failed to generate code suggestions for PR

static description = 'Samples a float curve at regular intervals';

declare inputs: ToInput<{
curve: FloatCurve;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you just allow someone to generate the sample points? Then they can have better control over whether they want to sample densely within 0.4->0.8 for example

@SorsOps SorsOps merged commit aa21dae into master Nov 12, 2024
2 checks passed
@SorsOps SorsOps deleted the sample-float branch November 12, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants