Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major V2 overhaul #79

Merged
merged 6 commits into from
Oct 3, 2023
Merged

Major V2 overhaul #79

merged 6 commits into from
Oct 3, 2023

Conversation

SorsOps
Copy link
Member

@SorsOps SorsOps commented Sep 7, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

🦋 Changeset detected

Latest commit: 43dd122

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@tokens-studio/graph-editor Major
@tokens-studio/graph-engine-ui Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

PR Analysis

  • 🎯 Main theme: Major V2 overhaul
  • 📝 PR summary: This PR is a major overhaul of the V2 codebase, including changes to the UI, editor, and other components.
  • 📌 Type of PR: Refactoring
  • 🧪 Relevant tests added: False
  • 🔒 Security concerns: No security concerns found

PR Feedback

  • 💡 General suggestions: The PR looks good overall, with significant changes to the codebase. However, it would be helpful to have more information in the PR description about the specific changes made and the reasoning behind them.

  • 🤖 Code feedback:

    • relevant file: packages/ui/src/panels/permutator.tsx
      suggestion: Consider breaking down the Permutator component into smaller, more focused components to improve modularity and reusability. [important]
      relevant line: export const Permutator = () => {

    • relevant file: packages/ui/src/pages/index.tsx
      suggestion: Remove the unused imports and variables to improve code cleanliness. [medium]
      relevant line: -import { Splitter } from '#/components/splitter.tsx';

    • relevant file: packages/graph-editor/src/editor/index.tsx
      suggestion: Refactor the EditorApp component to separate concerns and improve code readability. Consider extracting some logic into separate functions or components. [medium]
      relevant line: -import { DropPanel } from '../components/flow/DropPanel/Panel.tsx';

    • relevant file: packages/ui/src/components/editorMenu/index.tsx
      suggestion: Refactor the Menubar component to improve code organization and readability. Consider extracting subcomponents into separate files for better maintainability. [medium]
      relevant line: export const Menubar = () => {

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

six7 and others added 5 commits September 20, 2023 20:08
* initial commit

* overhaul ui

* fix italic styles

* adjust colors and layout

* more stuff

* fix broken build

* wip

* style update

* adjust menubar

* adjust layout

* adjust context menus

* adjust pr

* adjust style of droppanel

* remove sidesheet

* remove dropdown

* remove onConnectEnd

* clean up changes

* remove unused file

* fix print

* remove unused

* include cmd palette

---------

Co-authored-by: SorsOps <[email protected]>
* introduce group node

* Format, fix drag item and add group extract node

---------

Co-authored-by: SorsOps <[email protected]>
# Conflicts:
#	packages/documentation/yarn.lock
@SorsOps SorsOps merged commit 5070766 into master Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants