Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1825] Valid tile placements denied in some cases. #6468

Closed
alexarnon opened this issue Oct 23, 2021 · 18 comments · Fixed by #6517
Closed

[1825] Valid tile placements denied in some cases. #6468

alexarnon opened this issue Oct 23, 2021 · 18 comments · Fixed by #6517
Assignees
Labels
1825 minor bug A minor bug that doesn't impact game play (erronous logging)

Comments

@alexarnon
Copy link

alexarnon commented Oct 23, 2021

Game #58038: https://18xx.games/game/58038

Valid placements for AlexA are not allowed/possible, e.g.:

  1. X16 is greyed out, while it should allow placement of a # 52.
  2. X8 disallows even a simple # 7 (tight curve).
  3. W11 disallows any kind of double-dit tile that should be possible.

Game ID: AlexA

The above have been a problem since the beginning of the game, except for # 1 which appeared only on OR5.2 IIRC (we are playing a semi exploratory game).

I am using Firefox on Mac.

@roseundy roseundy self-assigned this Oct 23, 2021
@roseundy
Copy link
Collaborator

Cannot reproduce in hotseat - server issue.

@alexarnon
Copy link
Author

Cannot reproduce in hotseat - server issue.

It does indeed have a significant (2-3 sec) delay before displaying the error in the top bar, and reloading.

@roseundy
Copy link
Collaborator

Actually, I just get it to reproduce in hotseat. It might have something to do with undoing.

@roseundy
Copy link
Collaborator

It appears that in history mode, clicking on the map to place a tile causes the game to be reloaded and the hexes to be reinitialized. Normally this isn't a problem since the @hexes variable is just reassigned to the the HEXES constant. In 1825, I have to build @hexes from several sources. This means re-initializing hexes will result in a different set of objects which then causes problems.

@roseundy
Copy link
Collaborator

So I think this is strictly an issue in history mode. Do you have an example where you actually can't lay a tile? In history mode, you can't change game state anyway. In the game that you showed me, if you did an "undo" to the point that GWR operates, I think it works fine.

@roseundy
Copy link
Collaborator

Also, problem 1 is not a bug: X16 is no longer reachable since X14 was tokened out.

@roseundy roseundy added 1825 minor bug A minor bug that doesn't impact game play (erronous logging) and removed needs triage labels Oct 24, 2021
@alexarnon
Copy link
Author

Right, it was tokened out, sorry :)

@alexarnon
Copy link
Author

So I think this is strictly an issue in history mode. Do you have an example where you actually can't lay a tile? In history mode, you can't change game state anyway. In the game that you showed me, if you did an "undo" to the point that GWR operates, I think it works fine.

Sure, on X8 I can't place a tight turn (number 7).

@roseundy
Copy link
Collaborator

I've been able to lay that tile just fine. Using the back arrows doesn't work (that's the bug). I need to see the game currently at the point where the tile cannot be laid.

@alexarnon
Copy link
Author

OK, I'll note here. Should be by tomorrow.

@alexarnon
Copy link
Author

@roseundy it's now in OR, my turn.

@alexarnon
Copy link
Author

OK @roseundy , seems to work now!

@alexarnon
Copy link
Author

Well, not so much - the server refuses the above again (have gone forward, then restarted my turn, then problem started again.

@roseundy
Copy link
Collaborator

It looks fine from what I see, but since I'm not you I can't actually make the move. What error is it throwing when the server refuses your move?

@alexarnon
Copy link
Author

Screen Shot 2021-10-28 at 8 01 34

Screen Shot 2021-10-28 at 8 01 30

Again, it worked but when I'd placed the tile and then undid, it started throwing this error again.

@HerbyMcGee
Copy link

I have this issue with a different (non-server) error message.
https://18xx.games/game/61154?action=315
When trying to upgrade N13, it says LNWR is "Unable to reach city/town on upgraded tile with any train," which is not true.

The same thing happened when LNWR wanted to upgrade N12 earlier in the game.
https://18xx.games/game/61154?action=183

L&Y was able to upgrade N12 with no issues

@roseundy
Copy link
Collaborator

roseundy commented Nov 9, 2021

@HerbyMcGee, this appears to be a separate bug.

@HerbyMcGee
Copy link

I will create a new issue. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1825 minor bug A minor bug that doesn't impact game play (erronous logging)
Projects
None yet
3 participants