Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use str() to generate RSS #112

Open
tobinus opened this issue Jan 29, 2020 · 0 comments · May be fixed by #117
Open

Do not use str() to generate RSS #112

tobinus opened this issue Jan 29, 2020 · 0 comments · May be fixed by #117

Comments

@tobinus
Copy link
Owner

tobinus commented Jan 29, 2020

Currently, you can generate the RSS by converting the Podcast to RSS:

print(str(p))

However, this introduces a couple issues:

  • Multiple ways of achieving the same thing.
  • May accidentally cause the podcast RSS to be generated many times over, since users (rightly) think that str() should not be a costly operation.

For version 1.2.0, using str() to generate the RSS should yield DeprecationWarning.

For version 2.0.0, you can only use rss_str() to generate the RSS as string.

@nerok nerok linked a pull request Aug 8, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant