Add alias for all CSS specs #564

marcoscaceres · 2019-10-29T01:54:55Z

closes #563

marcoscaceres · 2019-10-29T02:06:01Z

@tobie, sorry, it's been a while since I worked on SpecRef... I was unsure if I should update "refs/w3c.json" or "biblio.json"? I guess "w3c.json" is right?

Also, I'm unsure what to do about the failing tests. Could you guide me a little bit?

tabatkins

Everything looks good after the one change to the grid alias.

refs/w3c.json

tobie · 2019-10-30T06:50:18Z

This is a great.

The reasons the tests are failing is that some of these aliases have already been added manually, probably both in w3c.json and biblio.json. Removing them manually once should fix it, as long as all of them are aliases (and none actually contain data).

Is there anything preventing us from adding the script to update-all so that it runs with automatic updates?

marcoscaceres · 2019-10-30T07:04:43Z

Is there anything preventing us from adding the script to update-all so that it runs with automatic updates?

No, that was going to be my next question :)

tobie · 2019-10-30T07:08:40Z

Awesome. Let’s do that. I have a few suggestions on the script itself that I’ll get to right away (for consistency with the rest of this mess🙃) and then we should be good to go.

tobie · 2019-10-30T07:09:47Z

Whereby rest of this mess I mean the whole code base, not your pull request.

marcoscaceres · 2019-10-30T08:03:18Z

Whereby rest of this mess I mean the whole code base, not your pull request.

It's all beautiful soup :) I also slapped mine together rather quickly, so appreciate the look over.

tobie

I think this makes it more consistent with the rest of the stuff.

tobie · 2019-10-30T09:32:37Z

scripts/update-all

-    node "./scripts/run.js" "./github" "whatwg.json";
+    node "./scripts/run.js" "./github" "whatwg.json" &&
+    node "./scripts/scripts/css-alias.js" &&
+    node "./scripts/list-refs.js"; # regenerate, as CSS aliases may have changed


Why are you regenerating that list here? This seems like a pretty big smell.

Yeah, you really can't do that. You're basically by-passing the whole check to verify that you're not removing entries by running this at this point.

Instead you need to figure out what entries are getting removed and add them automatically.

If, for example:

today "css-foo" references "css-foo-1",

tomorrow "css-foo" becomes "css-foo-2"

Now all the "css-foo-YYYYMMDD" references need to be updated... this is where is gets complicated. Perhaps "date citing" an an alias shouldn't be allowed. Or, we need to figure out how to retain these old references as more aliases.

Absolutely. I now remember why trying to fix this index issue in the past had made me sad.

The correct way of solving the problem is stacking everything onto "foo" including version numbers ("foo-1"), rec track status ("foo-1-CR"), and dated releases ("foo-YYYYMMDD") like so:

{ "css-grid": { "versions": { "1": {...}, "2": {...}, "20110407": {...}, "20120322": {...}, "20121106": {...}, "20130402": {...}, "20130910": {...}, "20140123": {...}, "20140513": {...}, "20150317": {...}, "20150806": {...}, "20150917": {...}, "20160519": {...}, "20160929": {...}, "20170209": {...}, "20170509": {...}, "20171214": {...}, "20180206": {...}, "20180427": {...}, "20180628": {...}, "20180804": {...} } } }

Compared to what we have which is more:

{ "css-grid-1": { "versions": { "20110407": {...}, "20120322": {...}, "20121106": {...}, "20130402": {...}, "20130910": {...}, "20140123": {...}, "20140513": {...}, "20150317": {...}, "20150806": {...}, "20150917": {...}, "20160519": {...}, "20160929": {...}, "20170209": {...}, "20170509": {...}, "20171214": {...} } }, "css-grid-2": { "versions": { "20180206": {...}, "20180427": {...}, "20180628": {...}, "20180804": {...} }, } }

This is actually hard to do given the existing data set.

Well, I guess even that has some limitations if there are two concurrent versions releasing new drafts on the same day. :-/

😭... indeed. ok... argh. Ok, it's doable. Need to find all "css-grid-*" can then clone all versions in. Will try tomorrow.

It might be worth merging this minus the changes to update-all, and really giving the data model some thought before committing to something else, there.

Yeah, having a dated reference to the unleveled ref doesn't make sense; either it only resolves to a particular version's dates (which then become invalid when a new version comes out and the unleveled ref moves) or it resolves to all of them (and then you can't disambiguate when two versions of a spec come out on the same day). The latter issue is definitely possible, especially now that we have such easier publishing via Echidna; I wouldn't be surprised if it had already happened, actually.

Yeah, having a dated reference to the unleveled ref doesn't make sense;

Agree.

The latter issue is definitely possible, especially now that we have such easier publishing via Echidna; I wouldn't be surprised if it had already happened, actually.

I has... I spotted one already.

Alright, so we'll have to maintain the existing ones for backwards compat and start anew with the rest. Maybe worth looking into the JSON API while we're at it?

refs/wicg.json

scripts/css-alias.js

tobie

Really need to fix the aliasing here, so that we don't lose any entries when the script is run.

test/ref-list.json

Co-Authored-By: Tobie Langel <[email protected]>

marcoscaceres · 2019-11-05T05:26:15Z

I'm struggling a bit :( The changes to "test/ref-list.json" would add unwanted refs keyed on version (which we don't want, based on the discussion here).

I'll revert the changes to "test/ref-list.json", but I think we still need to figure out how to change some assumptions we've made with referencing the aliasOf things that are going to break going forward.

I don't know yet how to cope with that... we might be in breaking change situation - or we might need a way of hard coding those legacy aliasOf generated references in "test/ref-list.json".

marcoscaceres · 2019-11-05T05:56:37Z

Ok... this gets us back into a "good state". However, running "scripts/list-refs.js" again now will generate the references we don't want anymore.

Let's see if we can figure out a good path forward.

ExE-Boss · 2020-01-20T13:39:00Z

It should probably now be possible to implement this using the framework introduced in #573.

marcoscaceres · 2020-01-20T23:46:51Z

@ExE-Boss, excellent! Should this be closed or could you provide me with some guidance for next steps?

sidvishnoi · 2020-05-04T11:18:57Z

Any updates on this?
Do we need to manually add all entries to overwrites/w3c.json? Can we safely redirect the output of this script to overwrites/w3c.json to add createAliasentries?

marcoscaceres · 2020-05-29T08:16:36Z

@tobie, @ExE-Boss, was waiting on next steps on this... @sidvishnoi is willing to take it over, but we need some guidance 🙏

tobie · 2020-05-29T09:45:44Z

My feeling is that to move forward with something like this will require a lot of refactoring.

The schema we have doesn’t really handle the different ways the different groups think about versioning. I don’t know that there’s a model that would work across the board, but maybe there are a couple?

Once we have a schema in place we‘ll also need to have have a migration story for the existing data and for the generated references.

Do we keep the latter around or do we deprecate them?

We’ll also probably need to rethink how the generated files are kept separated from one another. That has cause more problems than anticipated. Similarly, whether these should contain manual edits or not should be clarified, so should how overwriting works and why, etc.

Maybe there’s a shortcut here, but I’ve attempted it twice and failed both times.

tobie · 2020-06-01T10:08:36Z

In particular, you want to look at this comment and the following thread.

tobie · 2020-08-04T13:43:53Z

Should we close this and reopen something else once we have clarity as to how to move forward?

sidvishnoi · 2020-08-05T09:59:37Z

Agree. Lets close this for now.

marcoscaceres mentioned this pull request Oct 29, 2019

Clarification on CSS Cascade #563

Open

Add alias for all CSS specs

949daee

marcoscaceres force-pushed the css-aliases branch from 9e64233 to 949daee Compare October 29, 2019 02:35

tabatkins requested changes Oct 29, 2019

View reviewed changes

refs/w3c.json Show resolved Hide resolved

Allow overriding certain specs

54c397a

Fix tests, regenerate refs

03c9d63

tobie reviewed Oct 30, 2019

View reviewed changes

tobie requested changes Oct 30, 2019

View reviewed changes

test/ref-list.json Outdated Show resolved Hide resolved

marcoscaceres and others added 4 commits October 30, 2019 21:13

Apply suggestions from code review

edfb2fe

Co-Authored-By: Tobie Langel <[email protected]>

Reformat script

3234a29

revert changes to update-all

4d40c4b

revert changes

f242070

marcoscaceres added 2 commits November 5, 2019 16:37

Revert changes to scripts/list-refs.js

cb5a468

Alias css-values as css-values-3

afca68d

tobie mentioned this pull request Dec 2, 2019

HR-TIME should be an alias for the latest HR-TIME #571

Closed

sidvishnoi mentioned this pull request May 4, 2020

Consider adding things back w3c/contentEditable#6

Draft

sidvishnoi mentioned this pull request May 29, 2020

Fix color processing steps w3c/manifest#878

Merged

5 tasks

tobie closed this Aug 5, 2020

tobie deleted the css-aliases branch April 26, 2021 16:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add alias for all CSS specs #564

Add alias for all CSS specs #564

marcoscaceres commented Oct 29, 2019

marcoscaceres commented Oct 29, 2019

tabatkins left a comment

tobie commented Oct 30, 2019

marcoscaceres commented Oct 30, 2019

tobie commented Oct 30, 2019

tobie commented Oct 30, 2019

marcoscaceres commented Oct 30, 2019

tobie left a comment

tobie Oct 30, 2019

tobie Oct 30, 2019

marcoscaceres Oct 30, 2019

tobie Oct 30, 2019

tobie Oct 30, 2019

marcoscaceres Oct 30, 2019

tobie Oct 30, 2019

tabatkins Oct 30, 2019

marcoscaceres Nov 4, 2019

tobie Nov 4, 2019

tobie left a comment

marcoscaceres commented Nov 5, 2019

marcoscaceres commented Nov 5, 2019

ExE-Boss commented Jan 20, 2020

marcoscaceres commented Jan 20, 2020

sidvishnoi commented May 4, 2020

marcoscaceres commented May 29, 2020

tobie commented May 29, 2020

tobie commented Jun 1, 2020 •

edited

Loading

tobie commented Aug 4, 2020

sidvishnoi commented Aug 5, 2020

Add alias for all CSS specs #564

Add alias for all CSS specs #564

Conversation

marcoscaceres commented Oct 29, 2019

marcoscaceres commented Oct 29, 2019

tabatkins left a comment

Choose a reason for hiding this comment

tobie commented Oct 30, 2019

marcoscaceres commented Oct 30, 2019

tobie commented Oct 30, 2019

tobie commented Oct 30, 2019

marcoscaceres commented Oct 30, 2019

tobie left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tobie left a comment

Choose a reason for hiding this comment

marcoscaceres commented Nov 5, 2019

marcoscaceres commented Nov 5, 2019

ExE-Boss commented Jan 20, 2020

marcoscaceres commented Jan 20, 2020

sidvishnoi commented May 4, 2020

marcoscaceres commented May 29, 2020

tobie commented May 29, 2020

tobie commented Jun 1, 2020 • edited Loading

tobie commented Aug 4, 2020

sidvishnoi commented Aug 5, 2020

tobie commented Jun 1, 2020 •

edited

Loading