Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response should be able to exclude facet details #57

Closed
saibotsivad opened this issue Sep 14, 2023 · 1 comment · Fixed by #60
Closed

Response should be able to exclude facet details #57

saibotsivad opened this issue Sep 14, 2023 · 1 comment · Fixed by #60
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@saibotsivad
Copy link
Collaborator

If I make a search request, the response includes facets, and (as far as I can tell) does not include a way to exclude that map.

My thinking is it should be excluded by default, to be an opt in. This would be a breaking change.

In either case, there should definitely be a way to exclude it, and I don't see one as it can get very big.

@saibotsivad saibotsivad self-assigned this Sep 14, 2023
@saibotsivad saibotsivad added the enhancement New feature or request label Sep 14, 2023
@saibotsivad
Copy link
Collaborator Author

Maybe this is a bug? I can specify which facets to include, but if I make a request with no facets specified, like this:

http://localhost:3001/?page[size]=1&sort=-date&include[facets]=

then I get an error response like this:

{
  "error": {
    "name": "TypeError",
    "message": "Cannot read properties of undefined (reading 'keys')"
  }
}

so that's a bug for sure, and maybe fixing that bug is enough to resolve this ticket.

Be sure to update the docs to make this clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant