From f7f21c19c5e29039cd690800a5da23381e554ccd Mon Sep 17 00:00:00 2001 From: to-bar <46519524+to-bar@users.noreply.github.com> Date: Tue, 8 Oct 2019 15:04:20 +0200 Subject: [PATCH] Improvements after testing #536 --- .../download-requirements/centos-7/download-requirements.sh | 6 +++--- .../files/download-requirements/centos-7/requirements.txt | 1 - .../download-requirements/redhat-7/download-requirements.sh | 6 +++--- .../files/download-requirements/redhat-7/requirements.txt | 1 - 4 files changed, 6 insertions(+), 8 deletions(-) diff --git a/core/src/epicli/data/common/ansible/playbooks/roles/repository/files/download-requirements/centos-7/download-requirements.sh b/core/src/epicli/data/common/ansible/playbooks/roles/repository/files/download-requirements/centos-7/download-requirements.sh index 8864fb15d7..2e49251310 100644 --- a/core/src/epicli/data/common/ansible/playbooks/roles/repository/files/download-requirements/centos-7/download-requirements.sh +++ b/core/src/epicli/data/common/ansible/playbooks/roles/repository/files/download-requirements/centos-7/download-requirements.sh @@ -1,6 +1,6 @@ #!/usr/bin/env bash -# VERSION 1.2.3 +# VERSION 1.0.0 set -euo pipefail @@ -138,7 +138,7 @@ get_package_dependencies_with_arch() { # $1 reserved for result local package="$2" - local query_output=$(repoquery --requires --resolve --queryformat '%{name}.%{arch}' --archlist=x86_64,noarch "$package" 2>&1) || + local query_output=$(repoquery --requires --resolve --queryformat '%{name}.%{arch}' --archlist=x86_64,noarch "$package") || exit_with_error "repoquery failed for dependencies of package: $package with exit code: $?, output was: $query_output" if [[ -z $query_output ]]; then @@ -156,7 +156,7 @@ get_package_with_version_arch() { # $1 reserved for result local package="$2" - local query_output=$(repoquery --queryformat '%{ui_nevra}' --archlist=x86_64,noarch "$package" 2>&1) || + local query_output=$(repoquery --queryformat '%{ui_nevra}' --archlist=x86_64,noarch "$package") || exit_with_error "repoquery failed for package: $package with exit code: $?, output was: $query_output" # yumdownloader doesn't set error code if repoquery returns empty output diff --git a/core/src/epicli/data/common/ansible/playbooks/roles/repository/files/download-requirements/centos-7/requirements.txt b/core/src/epicli/data/common/ansible/playbooks/roles/repository/files/download-requirements/centos-7/requirements.txt index facfab1574..6a0f7c4e4b 100644 --- a/core/src/epicli/data/common/ansible/playbooks/roles/repository/files/download-requirements/centos-7/requirements.txt +++ b/core/src/epicli/data/common/ansible/playbooks/roles/repository/files/download-requirements/centos-7/requirements.txt @@ -8,7 +8,6 @@ yum-utils [packages] audit # for docker-ce -audit-libs # for docker-ce bash-completion ca-certificates cifs-utils diff --git a/core/src/epicli/data/common/ansible/playbooks/roles/repository/files/download-requirements/redhat-7/download-requirements.sh b/core/src/epicli/data/common/ansible/playbooks/roles/repository/files/download-requirements/redhat-7/download-requirements.sh index 0b5761f4e3..07fcd28e49 100644 --- a/core/src/epicli/data/common/ansible/playbooks/roles/repository/files/download-requirements/redhat-7/download-requirements.sh +++ b/core/src/epicli/data/common/ansible/playbooks/roles/repository/files/download-requirements/redhat-7/download-requirements.sh @@ -1,6 +1,6 @@ #!/usr/bin/env bash -# VERSION 1.2.3 +# VERSION 1.0.0 set -euo pipefail @@ -155,7 +155,7 @@ get_package_dependencies_with_arch() { # $1 reserved for result local package="$2" - local query_output=$(repoquery --requires --resolve --queryformat '%{name}.%{arch}' --archlist=x86_64,noarch "$package" 2>&1) || + local query_output=$(repoquery --requires --resolve --queryformat '%{name}.%{arch}' --archlist=x86_64,noarch "$package") || exit_with_error "repoquery failed for dependencies of package: $package with exit code: $?, output was: $query_output" if [[ -z $query_output ]]; then @@ -173,7 +173,7 @@ get_package_with_version_arch() { # $1 reserved for result local package="$2" - local query_output=$(repoquery --queryformat '%{ui_nevra}' --archlist=x86_64,noarch "$package" 2>&1) || + local query_output=$(repoquery --queryformat '%{ui_nevra}' --archlist=x86_64,noarch "$package") || exit_with_error "repoquery failed for package: $package with exit code: $?, output was: $query_output" # yumdownloader doesn't set error code if repoquery returns empty output diff --git a/core/src/epicli/data/common/ansible/playbooks/roles/repository/files/download-requirements/redhat-7/requirements.txt b/core/src/epicli/data/common/ansible/playbooks/roles/repository/files/download-requirements/redhat-7/requirements.txt index facfab1574..6a0f7c4e4b 100644 --- a/core/src/epicli/data/common/ansible/playbooks/roles/repository/files/download-requirements/redhat-7/requirements.txt +++ b/core/src/epicli/data/common/ansible/playbooks/roles/repository/files/download-requirements/redhat-7/requirements.txt @@ -8,7 +8,6 @@ yum-utils [packages] audit # for docker-ce -audit-libs # for docker-ce bash-completion ca-certificates cifs-utils