Difference in Instrumentation

[grantwest]

I have noticed that when instrumenting a file, instrumenting with File System mode results in different output than instrumenting with Server mode.

File System mode:
_$jscoverage['script.js']

Server Mode:
_$jscoverage['/script.js']

Notice the addition of the '/' in Server mode.

Based on what I have seen, it looks like the best fix would to be to change File System mode to also have the slash. (I could be very wrong)

I looked at trying to fix this myself, but I couldn't figure it out. The fact that this can happen suggests that there is some unnecessary code duplication somewhere. I also understand that I am probably the only person who this is affecting because of my unconventional use of the software, but I would be very appreciative if you fixed it.

Regards,
Grant

[tntim96]

I don't this is an issue, but it may be worth making it consistent. It is not occurring due to duplication or some code short-cut, it's just the implementation which can probably be easily changed.

The slash for web-server mode comes from the URI - line 444 of InstrumentingRequestHandler.java.

The URI for the file-system mode comes from line 399 of FileSystemInstrumenter.java.

I'll take a look.

[tntim96]

OK - I've fixed this. Can you rebase and re-test?