Proxy mode does not send headers to server when fetching .js files

[fujifish]

When running JSCover in proxy mode, and a .js file is requested, the ProxyService class does not send the original request headers to the actual server, causing behavior changes and some times complete failure, especially if the "Cookie" header is involved.

I've changed the ProxyService#getUrl method to send all of the original request headers, (except for the "Accept-Encoding" header) and everything worked perfectly after that.
here is the modified method:

public String getUrl(HttpRequest request) throws IOException {
        URL url = request.getUrl();
        HttpURLConnection conn = (HttpURLConnection) url.openConnection();
        Map<String, List<String>> clientHeaders = request.getHeaders();
        if (clientHeaders != null) {
            for (String header : clientHeaders.keySet()) {
                if (header.equalsIgnoreCase("accept-encoding")) {
                    continue;
                }
                List<String> values = clientHeaders.get(header);
                for (String value : values) {
                    conn.addRequestProperty(header, value);
                }
            }
        }
        return ioUtils.toString(conn.getInputStream());
    }

[tntim96]

Thanks. I'll just need to add a test to release. Also, why do you need to ignore the "Accept-Encoding" header?

[fujifish]

The "Accept-Encoding" header specifies to the server what type of encodings the client is willing to accept. An encoding is the format in which the response content is delivered, such as gzip.
If the "Accept-Encoding" header in the original request would contain for example "gzip" and the ProxyService would pass that along to the server, then the server would most likely respond with a content that is encoded in gzip. In such a case JSCover would have to unzip the content in order to instrument the .js file.
I thought it would just be easier to avoid all types of encodings altogether and receive the content as plain text.

[tntim96]

Makes sense - have committed and built release. PS - you're now added to the contributors list :)

[fujifish]

Great, Thanks!