Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Mozilla's Rhino AST Engine with Google's Closure Compiler's #255

Closed
tntim96 opened this issue Jul 9, 2017 · 0 comments
Closed
Assignees

Comments

@tntim96
Copy link
Owner

tntim96 commented Jul 9, 2017

Development on Rhino has all but stopped, however the closure-compiler, whose AST engine was originally based on Rhino, is still going strong. Converting from one to the other should be fairly straight-forward, and allow this project to support more JavaScript language features.

Work has already begun in the closure-compiler branch. The approach so far has been to take the most isolated classes, and write a second set of implementations and tests (e.g. see StatementBuilder and StatementBuilderCC, and StatementBuilderTest StatementBuilderCCTest.

Order of work will be like:

  1. Create CC version of StatementBuilder and test (Done)
  2. Create CC version of BranchStatementBuilder and test (Done)
  3. Create InstrumenterCCTest and re-write any implementation required to get all tests working (Done)
  4. Create InstrumentCCAndHighlightRegressionTest. Re-organize to make tests independent of the Rhino ones. (Done)
  5. Create BranchInstrumentorCCTest and get working (Done)
  6. Create BranchInstrumentorCCIntegrationTest and get working. Replace Rhino runtime evaluation with Nashorn (Done)
  7. Get all acceptance tests (i.e. HTML Unit) working (Done)
  8. Update documentation (Done)
  9. Add detailed release note or wiki page on what has changed
  10. Create 2.0 release swapping from Rhino to Closure Compiler
  11. Optional - Look at replacing Mozilla JSON parsing with something else - Gson

Any potential contributor's, let me know what can work on in the immediate future, and I'll create a new issue for that. Rather than replying here, please use https://gitter.im/JSCover/closure-compiler-conversion

@tntim96 tntim96 self-assigned this Jul 9, 2017
This was referenced Jul 13, 2017
@tntim96 tntim96 closed this as completed Jul 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant