cmd(): Explicit custom targets
#535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #535 +/- ##
==========================================
+ Coverage 88.66% 88.75% +0.08%
==========================================
Files 37 37
Lines 3969 3965 -4
Branches 575 574 -1
==========================================
Hits 3519 3519
+ Misses 308 304 -4
Partials 142 142 ☔ View full report in Codecov by Sentry. |
tony
force-pushed
the
cmd-refactor-target
branch
4 times, most recently
from
7a4fe80
to
1e0aeb1
Compare
tony
force-pushed
the
cmd-refactor-target
branch
from
1e0aeb1
to
72f4638
Compare
tony
added a commit
that referenced
this pull request
Mar 17, 2024
tony
added a commit
that referenced
this pull request
Mar 17, 2024
tony
added a commit
to tmux-python/tmuxp
that referenced
this pull request
Mar 17, 2024
This should alleviate issues with `-t` values of pane / shell commands. See also: - tmux-python/libtmux#535 - #915
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
-tchecks incmd()are breaking.send_keys()and potentially various other places where-tis passed as argument.Changes
*.cmd(): ExplicittargetRelated
-tin pane commands in session files tmuxp#915pane.send_keys()doesn't send cmd to correct pane when cmd has a-tflag #533