-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tmux_cmd): use shutil.which and only PATH to discover tmux #407
Conversation
Codecov Report
@@ Coverage Diff @@
## master #407 +/- ##
==========================================
- Coverage 88.74% 88.67% -0.08%
==========================================
Files 18 18
Lines 1875 1854 -21
==========================================
- Hits 1664 1644 -20
+ Misses 211 210 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
965aa66
to
c391749
Compare
@rockandska Do my commits on top look okay to you? Let me know if you have any feedback |
The And not sure if it is relevant, but I didn't removed kwargs from |
Fixed
I don't see this. |
v0.15.0a1: GitHub release, git tag, PyPI package pip install libtmux==0.15.0a1 |
@rockandska Thank you for this! Well done Much cleaner + standard library + more explicit and predictable |
Live in v0.15.0 |
Follow-up of #396 (comment)
Copy @mdeguzis