Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tmux_cmd): use shutil.which and only PATH to discover tmux #407

Merged
merged 4 commits into from
Aug 28, 2022

Conversation

rockandska
Copy link
Contributor

Follow-up of #396 (comment)

Copy @mdeguzis

@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #407 (7643b43) into master (fbddbc6) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
- Coverage   88.74%   88.67%   -0.08%     
==========================================
  Files          18       18              
  Lines        1875     1854      -21     
==========================================
- Hits         1664     1644      -20     
+ Misses        211      210       -1     
Impacted Files Coverage Δ
libtmux/common.py 86.46% <100.00%> (-0.48%) ⬇️
libtmux/conftest.py 90.47% <100.00%> (ø)
tests/test_common.py 98.30% <100.00%> (-0.07%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

libtmux/common.py Outdated Show resolved Hide resolved
tests/test_common.py Outdated Show resolved Hide resolved
@tony
Copy link
Member

tony commented Aug 28, 2022

@rockandska Do my commits on top look okay to you? Let me know if you have any feedback

@rockandska
Copy link
Contributor Author

rockandska commented Aug 28, 2022

@rockandska Do my commits on top look okay to you? Let me know if you have any feedback

The from shutil import which was pushed back during force push, I let you remove it

And not sure if it is relevant, but I didn't removed kwargs from tmux_cmd even if it is not used anymore

@tony
Copy link
Member

tony commented Aug 28, 2022

The from shutil import which was pushed back during force push, I let you remove it

Fixed

And not sure if it is relevant, but I didn't removed kwargs from tmux_cmd even if it is not used anymore

I don't see this.

@tony tony merged commit bbfee75 into tmux-python:master Aug 28, 2022
@tony
Copy link
Member

tony commented Aug 28, 2022

@rockandska @mdeguzis

v0.15.0a1: GitHub release, git tag, PyPI package

pip install libtmux==0.15.0a1

@tony
Copy link
Member

tony commented Aug 28, 2022

@rockandska Thank you for this! Well done

Much cleaner + standard library + more explicit and predictable

@rockandska rockandska deleted the fix/path_lookup branch August 30, 2022 09:44
@tony
Copy link
Member

tony commented Sep 10, 2022

Live in v0.15.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants