Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple configurations per project #143

Closed
thii opened this issue Aug 14, 2018 · 6 comments
Closed

Support multiple configurations per project #143

thii opened this issue Aug 14, 2018 · 6 comments

Comments

@thii
Copy link
Contributor

thii commented Aug 14, 2018

Enhancement Suggestion

Support multiple configurations (Romefile) per project and allow specifying which configuration it uses for each run.

Steps which explain the enhancement or reproduce the bug
N/A

Current behavior

Rome currently only support one configuration per project, which it takes from the Romefile in the project root directory.

Suggested behavior

Other than the current default setting, which Rome reads config from a Romefile file in the project root directory, Rome should allow specifying arbitrary Romefile for each run.

Examples

Romefile

[Cache]
  S3-Bucket = ios-dev-bucket

[RepositoryMap]
  Alamofire = Alamofire

Romefile.xcode10

[Cache]
  S3-Bucket = ios-dev-bucket

[RepositoryMap]
  Alamofire = static/Alamofire
rome download # read cache config from Romefile and download caches.

rome download --config Romefile.xcode10 # read cache config from Romefile.xcode10 and download caches.

Why would the enhancement be useful to most users

Some projects may have to support multiple version of Xcode or multiple version of Carthage at the same time. Dynamically frameworks are built and placed in Carthage/iOS/Build directory, while frameworks built with overrided MACH_O_TYPE = staticlib build setting are built and placed into Carthage/iOS/Build/Static directory. With the first Romefile, Rome won't see frameworks that were built into the Carthage/Build/iOS/Static directory. With the second Romefile.xcode10, Rome won't see frameworks that were built into the Carthage/Build/iOS directory.

Rome version:

v0.16.0.46

OS and version:

macOS 10.13.6 (17G65)

@tmspzz
Copy link
Owner

tmspzz commented Aug 14, 2018

Sounds good.

@tmspzz
Copy link
Owner

tmspzz commented Aug 24, 2018

@thii
Copy link
Contributor Author

thii commented Aug 27, 2018

@blender Looks like it works without any issue. Can you publish this version to CocoaPods?

@tmspzz
Copy link
Owner

tmspzz commented Aug 27, 2018

@thii sure, I just want to:

  • add integration tests
  • update readme

and then it's ready to go.

Check back in 1 hour or so.

@tmspzz
Copy link
Owner

tmspzz commented Aug 27, 2018

@thii it's all out there.

@thii
Copy link
Contributor Author

thii commented Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants