Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting via regex goes beyond match + cannot copy/paste on macOS #17

Open
working-name opened this issue Sep 15, 2020 · 9 comments

Comments

@working-name
Copy link

Hi there,

It looks like regex matching is sort of like a start spot for highlighting to continue indefinitely until a next regex is matched. I personally find it more useful if highlighting limits to the full match instead.

Screen Shot 2020-09-15 at 3 02 09 PM

https://regex101.com/r/C8Zn1H/1/ - that's what the debug regex should help mark as green.
https://regex101.com/r/C8Zn1H/2 - that's the error regex

As a secondary issue: I cannot copy/paste from log viewer at all, not even from the regular expression fields on 10.14.4 using latest linked dmg version 1.4.1.

@tmoreno
Copy link
Owner

tmoreno commented Dec 20, 2020

Hi Alan,

I've made the highlight feature work in that way because, for me, it's easier to read the logs files. I could add a checkbox to enable or disable this feature.

According to copy/paste, I can't test macOS devices, I usually develop on Windows and I'm using linux virtual machines for some testing, so it's hard for me to test on macOS but I will try.

Thanks for your feedback!

@tmoreno
Copy link
Owner

tmoreno commented Dec 29, 2020

Hi Alan,

I've just created a new branch where I've added the copy/paste support for macOS,

https://github.com/tmoreno/open-log-viewer/tree/feature/enable-copy-paste-on-macos

Could you build the app and check if the short cuts works correctly?

Thanks!

@styledev
Copy link

styledev commented Jan 27, 2021

@tmoreno I have tested that feature branch on my macOS Big Sur v11.1 and copying still does not work. To note, I am using CMD + C as I did not see a contextual menu or File navigation for copying.

@jhult
Copy link

jhult commented Apr 9, 2021

@styledev and @tmoreno,

I git cloned the repo, built and ran. At first, I didn't see the Edit menu either. Nor did copy/paste work. Then, I realized I didn't checkout the proper branch. Once I did git checkout enable-copy-paste-on-macos, and then rebuilt, copy/paste worked (macOS 11.3).

@jhult
Copy link

jhult commented May 14, 2021

@tmoreno, any chance you could merge this and release a new build?

@tmoreno
Copy link
Owner

tmoreno commented May 14, 2021

Hi @jhult @styledev @working-name

I've just published a new version with the macOS copy/paste shortcut fixed.

https://github.com/tmoreno/open-log-viewer/releases/tag/1.5.1

Enjoy!!

@working-name
Copy link
Author

@tmoreno awesome! Thank you so much, I can copy paste everywhere now. Using 10.15.7.

Sorry to be a nag but would it be possible to make the current match-everything-til-next-regex behavior optional? It's ok if not, it's still a HUGE help going through large logfiles that contain mostly useless things. Thank you, once again.

@jhult
Copy link

jhult commented May 17, 2021

@tmoreno, thanks! 1.5.1 works great with copy/paste on macOS 11.4 Beta.

@tmoreno
Copy link
Owner

tmoreno commented May 19, 2021

@tmoreno awesome! Thank you so much, I can copy paste everywhere now. Using 10.15.7.

Sorry to be a nag but would it be possible to make the current match-everything-til-next-regex behavior optional? It's ok if not, it's still a HUGE help going through large logfiles that contain mostly useless things. Thank you, once again.

Hi @working-name!

Currently, I'm working in other side project and I don't have enough free time 😅

I have planned to do this, and other features, as soon as possible.

Thanks for your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants