Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer rollback process should be clean and accurate. #391

Open
deepusundar opened this issue Nov 20, 2018 · 1 comment
Open

Installer rollback process should be clean and accurate. #391

deepusundar opened this issue Nov 20, 2018 · 1 comment
Labels
enhancement wip work in progress

Comments

@deepusundar
Copy link
Contributor

deepusundar commented Nov 20, 2018

The uninstall or rollback process should be clean and accurate. This is applicable when an existing functioning stack is being deleted or when the installer itself rollbacks when an error occurs while installing Jazz. This is also important from a security point of view as well (Example: leaving out credentials in Jenkins without clean up)

To Reproduce
Install Jazz with a user with insufficient privileges, the installer will fail in the middle of the process sometimes after provisioning resources (which should not ideally). Now running the delete script would also fail with permissions errors

Expected behavior
Clean and rollback should be done gracefully in an all scenarios and intimate user if anything left out

@bleggett
Copy link
Contributor

bleggett commented Nov 29, 2018

We are in the process of abandoning the deletion script. Terraform should be expected to do the vast majority of the destruction for us.

The only spots where teardown isn't clean are the spots where we've done end-runs around Terraform.

That should solve your issue.

@bleggett bleggett added the wip work in progress label Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement wip work in progress
Projects
None yet
Development

No branches or pull requests

2 participants