Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded runtimes #322

Open
svidhani opened this issue Aug 20, 2018 · 1 comment
Open

Remove hardcoded runtimes #322

svidhani opened this issue Aug 20, 2018 · 1 comment

Comments

@svidhani
Copy link
Contributor

As new runtimes get released by AWS (and other cloud platforms) we cannot have hardcoded values in our codebase. We need to come up with a better way(config for eg.) to support the runtimes.

@bleggett
Copy link
Contributor

bleggett commented Oct 4, 2018

@svidhani and I were talking as a consequence of #366 , and we both think that we should simply stop maintaining a list of what core services target which runtime (see for instance line 28-30 of modifyCodebase.sh and should simply force all core services to use one runtime, defined in one variable, preferably the latest LTS.

I cannot see a good reason to avoid doing this that does not boil down to "well but then we would have to keep our core functions up to date"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants