Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aspect ratio of pictures is not perserved on display size change. #24

Open
hisbaan opened this issue Dec 4, 2021 · 0 comments
Open
Labels
bug Something isn't working

Comments

@hisbaan
Copy link
Contributor

hisbaan commented Dec 4, 2021

Describe the bug
The aspect ratio of the images next to articles and feeds in ArticleCard and FeedCard do not have a constant aspect ratio on different size phone screens. On one phone, it may be square, while on others, it can be a taller rectangle.

To Reproduce
Steps to reproduce the behaviour:

  1. Get a phone with a taller aspect ratio that has a thinner aspect ratio than 2:1.
  2. Open the application.

Expected behaviour
The aspect ratio should be consistent across all devices

Screenshots
Taller aspect ratio:
unknown

Wider aspect ratio:
Screenshot_20211204-103639

Notice that neither of these two have "square" images as is intended. One is too tall, the other is two wise, running the same code base.

@hisbaan hisbaan added the bug Something isn't working label Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant