Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not print pokemon, choice: unown-c #13

Closed
moiaune opened this issue Mar 10, 2022 · 2 comments
Closed

Does not print pokemon, choice: unown-c #13

moiaune opened this issue Mar 10, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@moiaune
Copy link

moiaune commented Mar 10, 2022

So I just ran the fortune | pokesay command a few times and then this showed up without any pokemon. Notice the "choice: unown-c".

This was on macOS with version 0.5.3.

➜ fortune | pokesay
/----------------------------------------------------------------------------------\
| [A computer is] like an Old Testament god, with a lot of rules and no mercy.      |
|         -- Joseph Campbell                                                        |
\----------------------------------------------------------------------------------/
         \
          \
           \
            \
choice: unown-c / categories: [PokemonGen7xRegularUnownCCow]
@tmck-code
Copy link
Owner

Thanks for opening an issue @madsaune! I'll look into this

@tmck-code tmck-code self-assigned this Mar 15, 2022
@tmck-code tmck-code added the bug Something isn't working label Mar 15, 2022
@tmck-code
Copy link
Owner

I've merged a PR that fixes this, thanks for submitting the issue! :shipit:

When converting the pokesprite pngs -> cowfiles, the img2xterm tool fails to convert some of them and results in empty data. I now skip over these, and I've double-checked that the offenders have been removed

  • before
     ☯ ~/d/p/build for f in $(find -iname unown-l*) ; do ls -alh $f && cat $f ; done
     
     -rw-r--r-- 1 freman freman 0 Mar 16 22:22 ./cows/pokemon-gen7x/regular/unown-l.cow
     -rw-r--r-- 1 freman freman 0 Mar 16 22:22 ./cows/pokemon-gen7x/regular/right/unown-l.cow
     -rw-r--r-- 1 freman freman 1.3K Mar 16 22:22 ./cows/pokemon-gen7x/shiny/unown-l.cow
     -rw-r--r-- 1 freman freman 1.2K Mar 16 22:22 ./cows/pokemon-gen7x/shiny/right/unown-l.cow
     -rw-r--r-- 1 freman freman 0 Mar 16 22:22 ./cows/pokemon-gen8/regular/unown-l.cow
     -rw-r--r-- 1 freman freman 1.3K Mar 16 22:22 ./cows/pokemon-gen8/shiny/unown-l.cow
    
  • after
     ☯ ~/d/p/build for f in $(find -iname unown-l*) ; do ls -alh $f && cat $f ; done
    
    -rw-r--r-- 1 freman freman 1.3K Mar 16 22:30 ./cows/pokemon-gen7x/shiny/unown-l.cow
    -rw-r--r-- 1 freman freman 1.2K Mar 16 22:30 ./cows/pokemon-gen7x/shiny/right/unown-l.cow
    -rw-r--r-- 1 freman freman 1.3K Mar 16 22:30 ./cows/pokemon-gen8/shiny/unown-l.cow
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants