Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove connection: close headers override #28

Closed
0xtsukino opened this issue Nov 15, 2023 · 2 comments
Closed

Remove connection: close headers override #28

0xtsukino opened this issue Nov 15, 2023 · 2 comments

Comments

@0xtsukino
Copy link
Collaborator

0xtsukino commented Nov 15, 2023

Currently we have to override Connection and Accept-Encoding in order to for a request to work. Need to investigate why these overrides are needed, and find solutions to remove headers override from notarization flow. The request theoretically should work with just headers from user browser history.

Edit 1: overriding request header with accept-encoding: identity is expected behavior

@themighty1
Copy link
Member

@0xtsukino, the prover uses accept-encoding: identity to tell the server not to use http compression (like gzip) for the response.
If the server sent a compressed response, the parties would have to decompress it in MPC which would be prohibitively expensive.

@0xtsukino
Copy link
Collaborator Author

Thanks @themighty1 - that makes sense, so accept-encoding: identity is expected behavior.

@0xtsukino 0xtsukino changed the title Remove connection: close; accept-encoding: identity headers override Remove connection: close headers override Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants