Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collaborators retroactively #1949

Closed
waldyrious opened this issue Jan 28, 2018 · 6 comments
Closed

Add collaborators retroactively #1949

waldyrious opened this issue Jan 28, 2018 · 6 comments
Assignees
Labels
community Issues/PRs dealing with role changes and community organization.

Comments

@waldyrious
Copy link
Member

Since #1839 and #1897, we now have explicit guidelines for when to invite regular contributors to become collaborators in the repository.

As I mentioned in #1878 (particularly in the opening comment, and in this one), for now we just added the contributors who have been particularly active recently (@pxgamer and @jsonbruce), but we'll eventually want to parse the entire list of contributors and assess them against the newly adopted thresholds.

Besides it being only fair to apply the same metrics to everyone, it would also very beneficial for the project to do this: we'd be empowering a bunch of prolific contributors to help out with management and onboarding, and perhaps we'll even spark one or two back to more active participation.

In case anyone wants to tackle this, some potentially helpful notes can be found in the entry a) of #1878's opening comment. Otherwise, I'll try to carve out a suitable time slot do do this (although I suspect it may take a while until I get that kind of availability).

@waldyrious waldyrious added the community Issues/PRs dealing with role changes and community organization. label Jan 29, 2018
@waldyrious waldyrious self-assigned this Jan 29, 2018
@zlatanvasovic
Copy link
Contributor

What's actually the issue in this? Every contributor in the list has at least 5 commits, which fits the threshold.

Now, if you want it to be automated, there may be a solution. tldr-bot can watch for every merge, and check if the number of PRs merged by PR's author so far on https://github.com/tldr-pages/tldr/pulls?utf8=%E2%9C%93&q=is%3Amerged+is%3Apr+author%3A{{name}} (where only {{name}} needs to be changed).

@waldyrious
Copy link
Member Author

Every contributor in the list has at least 5 commits, which fits the threshold.

The threshold is not 5 commits, though. Quoting the linked page:

once a contributor has had 5 non-trivial pull requests merged

So one would have to manually assess the PRs in order to validate this threshold.

(Of course, this metric can be questioned if we think we could get another one that is easier to apply while still working as a good predictor of future contributions.)

@zlatanvasovic
Copy link
Contributor

zlatanvasovic commented Jan 2, 2020

That's true, but I put it this way on purpose. How wrong is it to assume someone with 6-7 commits has at least 5 PRs merged? Maybe a little bit, but it cuts the time you need to spend on this task by an order of magnitude.

@agnivade
Copy link
Member

agnivade commented Jan 3, 2020

There's no urgency to add collaborators. I would prefer that we keep it manual so that a human element is maintained. It may be lengthier, but there is no urgency to finish it quickly also.

@sbrl
Copy link
Member

sbrl commented Jan 6, 2020

Also, you can filter PRs by merged + author, which is what I do when opening issues for role changed.

@CleanMachine1
Copy link
Member

CleanMachine1 commented Aug 13, 2022

I am going to close this PR, since it is more than stale and there is no real reason to add contributors who have clearly stopped contributing.

Contributors have been added as they contribute actively (at least while I have started).

Feel free to open again if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues/PRs dealing with role changes and community organization.
Projects
Development

No branches or pull requests

5 participants