Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfair comparison, your method has 100x higher lr #28

Open
grypesc opened this issue Oct 24, 2023 · 0 comments
Open

Unfair comparison, your method has 100x higher lr #28

grypesc opened this issue Oct 24, 2023 · 0 comments

Comments

@grypesc
Copy link

grypesc commented Oct 24, 2023

if args.loss == 'Proxy_Anchor':
param_groups.append({'params': criterion.parameters(), 'lr':float(args.lr) * 100})
elif args.loss == 'Proxy_NCA':
param_groups.append({'params': criterion.parameters(), 'lr':float(args.lr)})

Why do you multiply yours lr by 100, but not the other method? In the teaser you claim your method trains faster, but it seems it is due to 100x higher lr.

@grypesc grypesc changed the title Unfair comparison, your methods has 100x higher lr Unfair comparison, your method has 100x higher lr Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant