-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should pass node options or v8 options to the subcommend exec process #877
Comments
or these node options can be passed by ENV |
Hello there can you please elaborate on it, I'm not sure I have correctly understood you |
for example,when the command running with large memory and deep stacks, i need pass v8 options to the node process,like: > customCmd subcmd --max_old_space_size=2048 --stack_size=1024 other_options now commander will treated these v8 options as unknow arguments and passed to the subcmd。 |
Hi, Thanks for pointing that out. I will create a pull request about this. |
@fishbar |
@fishbar are you on Windows? (There is code passing the extra arguments for javascript subcommands when not on Windows.) |
This will hopefully be fixed by #611 |
This issue will be resolved when v3.0.0 is released. Available now as a prerelease. See #1001 |
Support for passing node options added in v3 (thanks @hxsf): https://github.com/tj/commander.js/releases/tag/v3.0.0 |
when subcommand executing, the unknow args will passed to the sub process which spawn by the function above. but if the args is belong to node(
node options or v8 options), it will fail。
for example, when the subcommand deal with something which needs large mem, so we need to setup the v8 options
--max_old_space_size =2048
, for now themax_old_space_size
will be treatedas unknow options, so the process which running the subCommand can not receive these options.
The text was updated successfully, but these errors were encountered: