-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move parsed options into a data object #514
Comments
I've implemented the proposed changes with some helper methods in a forked feature branch. Still need to write tests for the new commands. https://github.com/ericuldall/commander.js/tree/data_overload New features allow the following:
|
Pull request sent and all tests passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First off, I really like this plugin. I've written argv parsing snippets more times than I like and they always come out different. This is a much needed piece of code.
One thing I think would be a good addition is moving all the parsed options into a data object. This would allow us to abstract away all the private data from the public data a user is trying to access.
Instead of
We can do
I haven't dug too deep into this packages code, so perhaps there's an implementation detail that makes storing data this way less than simple. If not, then I'd like to see it work this way.
The text was updated successfully, but these errors were encountered: