Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot use --parent argument #1401

Closed
manolo opened this issue Nov 25, 2020 · 3 comments
Closed

cannot use --parent argument #1401

manolo opened this issue Nov 25, 2020 · 3 comments
Milestone

Comments

@manolo
Copy link

manolo commented Nov 25, 2020

cmd.parent is used internally, it should be a private name like cmd._parent to allow usage of parent which should be a valid option, for instance in apps doing file-system operations.

@shadowspawn
Copy link
Collaborator

There are LOTS of properties, including parent. This problem has a long history: #933

However, the good news is there is a solution now! Use .storeOptionsAsProperties(false), see:

https://github.com/tj/commander.js#avoiding-option-name-clashes

@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Dec 20, 2020
@shadowspawn shadowspawn added this to the v7.0.0 milestone Dec 20, 2020
@shadowspawn
Copy link
Collaborator

An answer was provided, and no further activity in a month. Closing this as resolved.

Feel free to open a new issue if it comes up again, with new information and renewed interest.

@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Jan 15, 2021
@shadowspawn
Copy link
Collaborator

Options are now stored safely by default in Commander 7.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants