Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] No changes found even if I commit changes on the specified files #291

Closed
3 tasks done
thierryskoda opened this issue Apr 19, 2023 · 3 comments
Closed
3 tasks done
Labels
bug Something isn't working

Comments

@thierryskoda
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Does this issue exist in the latest version?

  • I'm using the latest release

Describe the bug?

Here's what I'm using in my Github action:

- name: Verify Changed files
        uses: tj-actions/verify-changed-files@v14
        id: verify-changed-files
        with:
          files: |
            apps/hcp-app/version.json
            yarn.lock

This action is triggered on every commit on the branch main.

I tried many times to push changes on yarn.lock or apps/hcp-app/version.json but it always says no changes found

Here are some screenshot from the Github action

image

image

To Reproduce

  1. Create a monorepo
  2. Create 1 package with the file version.json (apps/hcp-app/version.json)
  3. Create the GitHub action with this step:
- name: Verify Changed files
        uses: tj-actions/verify-changed-files@v14
        id: verify-changed-files
        with:
          files: |
            apps/hcp-app/version.json
            yarn.lock
  1. Make your Github action run on every push to the main branch
  2. Edit the version.json file and push to main
  3. Wait for the job to finish and look if the step detected the changes

What OS are you seeing the problem on?

ubuntu-latest or ubuntu-20.04

Expected behavior?

I expected to see that yarn.lock has changed.

Relevant log output

Uploaded in the description above

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@thierryskoda thierryskoda added the bug Something isn't working label Apr 19, 2023
@github-actions
Copy link
Contributor

Thanks for reporting this issue, don't forget to star this project if you haven't already to help us reach a wider audience.

@thierryskoda thierryskoda changed the title [BUG] <title> [BUG] No changes found even if I commit changes on the specified files Apr 19, 2023
@jackton1
Copy link
Member

Hi @thierryskoda

NOTE: ⚠️

This action only detects files that have pending uncommited changes generated during the workflow execution, for running a specific step when a file changes in a pull request or based on a new pushed commit

See: https://github.com/tj-actions/changed-files

@jackton1 jackton1 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 20, 2023
@thierryskoda
Copy link
Author

@jackton1 Oh my bad. Thank you for pointing me out to the right place 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants