Add native json.Number support #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow encoding and decoding of `json.Number` values, either as struct members or as interface members. Numbers will be encoded as integer, if possible, otherwise float64 is used. To cover the zero values, write an empty string, but invalid values will return errors when encoded It is possible to encode as string with `//msgp:replace json.Number with:string`. Fixes tinylib#292
The behavior of |
|
Good point. Also makes the output more reliable and guaranteed to be a number type. |
|
Amended, and now will also optionally use float32 as per #365 |
philhofer
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow encoding and decoding of
json.Numbervalues, either as struct members or as interface members.Numbers will be encoded as integer, if possible, otherwise float64 is used. The zero value json.Number will be encoded as 0.
It is possible to encode as string with
//msgp:replace json.Number with:string.Fixes #292
Review notes
I think the only contentious part is that it refuses to encode invalid values, which seems reasonable to me, so the output will either be float or integer or an empty string.Empty string or null, for a "zero value" (not 0)? A bit undecided on this. Open to changes.