Manage non-[]byte types when type-conversion needed from generated code #312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of the code below:
While
go generate
thetinylib/msgp
lib expected type as []byte and doesn't use the function proveded for conversion. See as example the expected generated code as a diff:The representation of the UUID behind
github.com/gofrs/uuid
is an [16]byte (an array and not a slice of byte). So the actual hardcoded []byte cast not working.Btw, this bug is only related to the
DecodeMsg()
func and not to theUnmarshalMsg()
func because it reuse well the conversion function provided by the go annotation. That's why the fix is inspired by this second function to correct the first.This PR allow to fix this kind of issue without crashing existing tests.