Make array on decode if it's not supposed to be nil #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I help out somehow to speed up merge of this one? |
|
I suppose a few tests would help. |
klauspost
added a commit
to klauspost/msgp
that referenced
this pull request
Oct 27, 2023
When `allownil` is enabled, always allocate zero length slices. This ensures roundtrips with 0-length slices are not returned as nil. Replaces tinylib#304 Adds tests. Bonus: Don't shell out to test issue 94.
|
@makarchuk I have added #336 When looking at this, I would expect the additional allocations to be a significant downside for current users. Instead I've added it to That would make |
klauspost
added a commit
that referenced
this pull request
Feb 10, 2024
* allownil: Allocate 0 length slices When `allownil` is enabled, always allocate zero length slices. This ensures roundtrips with 0-length slices are not returned as nil. Replaces #304 Adds tests. Bonus: Don't shell out to test issue 94.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #278. #302 fixed issue only partially. It serialized non-nil empty
sliceas it should, but on decode it deserialized asnilanyway.This PR addresses this "issue".
I'm open to any suggestions on code improvement for this one