Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several Generation Issues #203

Closed
ColtonProvias opened this issue Sep 25, 2017 · 1 comment · May be fixed by #204
Closed

Several Generation Issues #203

ColtonProvias opened this issue Sep 25, 2017 · 1 comment · May be fixed by #204

Comments

@ColtonProvias
Copy link

I'm having issues where the code being generated is rather error-filled. Missing elses and forced conversions when shimming are the primary issues.

As an example:

https://gist.github.com/ColtonProvias/c5a020bb8ba42942689d114488568354

Line 24 in sample_gen.go attempts to force a conversion that throws an error during compilation. And just 2 lines above an else is missing in the generated code.
@philhofer philhofer mentioned this issue Sep 25, 2017
Open
@klauspost
Copy link
Collaborator

The provided example now works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use the appropriate base conversion in decode generation tinylib/msgp
2 participants
@ColtonProvias @klauspost