Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base24 mbadolato iterm2 #13

Open
wants to merge 6 commits into
base: spec-0.11
Choose a base branch
from
Open

Base24 mbadolato iterm2 #13

wants to merge 6 commits into from

Conversation

FredHappyface
Copy link

Close #10

Adds all iterm2 schemes from the https://github.com/Base24/base24-mbadolato-iterm2-color-schemes repo to this repo under the base24 directory

@JamyGolden
Copy link
Member

I've pushed 2 commits, I was going to suggest the change but thought I could just do it and push. The two changes were:

  • Wrap all hex values in double quotes. This is how all the others are and in this PR some base0x colours had single quotes (when they were numbers) and others didn't so this makes it more consistent imo.
  • Rename schemes that have capital letters to be lowercase and rename Dark+.yaml to dark-plus.yaml. This isn't something we enforce, but I think we should have the scheme names match the scheme slug. @belak?

@FredHappyface
Copy link
Author

Ah I thought I'd fixed the casing. Pesky windows :(

@JamyGolden
Wrap hex values in quotes
3288fb9 
Wrap in quotes to have consistency across all schemes
@JamyGolden
Rename schemes to lowercase
cfa8613
JamyGolden
JamyGolden approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@JamyGolden JamyGolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just made a few comments about schemes that seem to be light themes but have variant "dark". After those have been looked at this looks good to me!

base24/unikitty.yaml
author: "FredHappyface (https://github.com/fredHappyface)"
variant: "dark"
palette:
base00: "ff8cd9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a light theme

base24/man-page.yaml
author: "FredHappyface (https://github.com/fredHappyface)"
variant: "dark"
palette:
base00: "fef49c"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Light theme variant

base24/terminal-basic.yaml
author: "FredHappyface (https://github.com/fredHappyface)"
variant: "dark"
palette:
base00: "ffffff"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Light variant

@FredHappyface
Copy link
Author

Cheers for the review! Aiming to get those addressed this week :)

@belak
Copy link
Member

belak commented Apr 1, 2024

Rename schemes that have capital letters to be lowercase and rename Dark+.yaml to dark-plus.yaml. This isn't something we enforce, but I think we should have the scheme names match the scheme slug.

This is an interesting case - I'm interested to know how base24 has been handling the scheme slug in these scenarios? In general I try to make sure the file name matches what the slug property or slugified name would be.

@donovanglover
Copy link
Contributor

+1 since this would make base24 schemes comparable to the amount of base16 ones. Would also be cool to have a gallery similar to Base16 Gallery.

@FredHappyface FredHappyface requested a review from a team as a code owner August 26, 2024 14:52
@FredHappyface
Copy link
Author

FredHappyface commented Aug 26, 2024 •
edited
Loading

Sorry for the delay! Addressed the comments. Lmk if you've any additional thoughts? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamyGolden JamyGolden JamyGolden approved these changes

@belak belak Awaiting requested review from belak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate https://github.com/Base24/base24-mbadolato-iterm2-color-schemes
4 participants
@FredHappyface @JamyGolden @belak @donovanglover