fix(kit): TuiInputFilesDirective does not provide capture attribute if null
#4216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sviat9440
requested review from
waterplea,
MarsiBarsi,
vladimirpotekhin and
nsbarsukov
as code owners
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
BundleMonFiles updated (1)
Unchanged files (4)
Total files change +25B 0% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
waterplea
reviewed
Apr 14, 2023
projects/kit/components/input-files/test/input-files.directive[#4215].spec.ts
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4216 +/- ##
=======================================
Coverage 61.32% 61.32%
=======================================
Files 1618 1618
Lines 18997 18997
Branches 2683 2683
=======================================
+ Hits 11649 11650 +1
+ Misses 6868 6867 -1
Partials 480 480
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
splincode
approved these changes
Apr 14, 2023
splincode
reviewed
Apr 14, 2023
| ).capture ?? this.options.capture | ||
| ); | ||
| this.el.nativeElement.getAttribute('capture') as TuiInputFilesOptions['capture'] | null | ||
| ) ?? this.options.capture; |
There was a problem hiding this comment.
getAttribute will return null if there is no attribute, so it's more correct here ??
splincode
changed the title
TuiInputFilesDirective does not provide capture attribute if null
waterplea
approved these changes
Apr 14, 2023
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
TuiInputFilesDirective always provide capture attribute
Closes #4215
What is the new behavior?
TuiInputFilesDirective does not provide capture attribute if
nullDoes this PR introduce a breaking change?