Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Dialog fix close button appearance on mobile #4204

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Conversation

waterplea
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Apr 13, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 889c469):

https://taiga-ui--pr4204-dialog-close-scyqe77y.web.app

(expires Fri, 14 Apr 2023 09:33:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon
Copy link

bundlemon bot commented Apr 13, 2023

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
320.71KB +10%
demo/browser/vendor.(hash).js
190.88KB +10%
demo/browser/runtime.(hash).js
36.98KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%

Total files change +7B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.16MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (87822ea) 61.30% compared to head (889c469) 61.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4204   +/-   ##
=======================================
  Coverage   61.30%   61.30%           
=======================================
  Files        1617     1617           
  Lines       18991    18991           
  Branches     2670     2670           
=======================================
  Hits        11643    11643           
  Misses       6868     6868           
  Partials      480      480           
Flag Coverage Δ
addon-charts 72.03% <ø> (ø)
addon-doc 50.22% <ø> (ø)
addon-editor 49.53% <ø> (ø)
addon-mobile 61.88% <ø> (ø)
addon-table 61.06% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 40.91% <ø> (ø)
core 76.95% <100.00%> (ø)
kit 72.68% <ø> (ø)
summary 61.30% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rojects/core/components/dialog/dialog.component.ts 76.66% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode merged commit 7f13930 into main Apr 13, 2023
@splincode splincode deleted the dialog-close branch April 13, 2023 11:33
@well-done-bot
Copy link

well-done-bot bot commented Apr 13, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants