Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-charts): LineDaysChart fix hint circle not disappearing, fix wrong hover index #4178

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

vladimirpotekhin
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #3516

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Apr 10, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Apr 10, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/runtime.(hash).js
36.98KB (-21B -0.06%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/main.(hash).js
340.23KB +10%
demo/browser/vendor.(hash).js
204.47KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
18.08KB +10%

Total files change -21B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.22MB (+90B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 2eb3b1e):

https://taiga-ui--pr4178-line-chart-fix-879nrhp2.web.app

(expires Tue, 11 Apr 2023 15:32:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (94f283d) 61.34% compared to head (2eb3b1e) 61.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4178   +/-   ##
=======================================
  Coverage   61.34%   61.34%           
=======================================
  Files        1616     1616           
  Lines       18977    18977           
  Branches     2664     2664           
=======================================
  Hits        11642    11642           
  Misses       6856     6856           
  Partials      479      479           
Flag Coverage Δ
addon-charts 72.03% <100.00%> (ø)
addon-doc 50.22% <ø> (ø)
addon-editor 49.46% <ø> (ø)
addon-mobile 61.88% <ø> (ø)
addon-table 61.06% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 41.02% <ø> (ø)
core 76.96% <ø> (ø)
kit 72.68% <ø> (ø)
summary 61.34% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...arts/components/line-chart/line-chart.component.ts 18.75% <ø> (ø)
...components/line-chart/line-chart-hint.directive.ts 23.52% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vladimirpotekhin vladimirpotekhin merged commit ae7edc9 into main Apr 11, 2023
@vladimirpotekhin vladimirpotekhin deleted the line-chart-fix branch April 11, 2023 08:17
@well-done-bot
Copy link

well-done-bot bot commented Apr 11, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - Cursor position dot doesnt hide after mouse leave chart
3 participants