Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): add no-typeof rule #3449

Merged
merged 3 commits into from
Jan 19, 2023
Merged

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #3185

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jan 18, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Jan 18, 2023

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
332.99KB (+81B +0.02%) +10%
demo/browser/runtime.(hash).js
34.69KB (-14B -0.04%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
204.87KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

Total files change +67B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.21MB (+67B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2023

Visit the preview URL for this PR (updated for commit 990335b):

https://taiga-ui--pr3449-splincode-feat-issue-ro0d1bx4.web.app

(expires Fri, 20 Jan 2023 08:43:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@splincode splincode force-pushed the splincode/feat/issues/3185 branch from cb47af2 to 421e174 Compare January 18, 2023 13:00
@splincode splincode force-pushed the splincode/feat/issues/3185 branch from 421e174 to 801a360 Compare January 18, 2023 13:30
@splincode splincode force-pushed the splincode/feat/issues/3185 branch 2 times, most recently from b2792c0 to b4a59ed Compare January 18, 2023 15:36
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 61.23% // Head: 61.31% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (990335b) compared to base (926bb66).
Patch coverage: 54.54% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3449      +/-   ##
==========================================
+ Coverage   61.23%   61.31%   +0.08%     
==========================================
  Files        1535     1537       +2     
  Lines       18200    18243      +43     
  Branches     2544     2545       +1     
==========================================
+ Hits        11145    11186      +41     
- Misses       6587     6590       +3     
+ Partials      468      467       -1     
Flag Coverage Δ
addon-charts 72.34% <ø> (ø)
addon-doc 49.87% <ø> (ø)
addon-editor 50.40% <ø> (+0.05%) ⬆️
addon-mobile 61.73% <ø> (+0.04%) ⬆️
addon-table 60.87% <ø> (+0.08%) ⬆️
addon-tablebars 98.11% <ø> (+0.03%) ⬆️
cdk 40.31% <44.44%> (+0.34%) ⬆️
core 76.83% <ø> (+0.03%) ⬆️
kit 72.85% <100.00%> (+0.02%) ⬆️
summary 61.31% <54.54%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...update/v3/steps/migrate-taiga-proprietary-icons.ts 0.00% <0.00%> (ø)
...cdk/schematics/utils/angular-json-manipulations.ts 0.00% <0.00%> (ø)
projects/cdk/utils/miscellaneous/is-number.ts 100.00% <ø> (ø)
projects/cdk/utils/miscellaneous/is-string.ts 100.00% <ø> (+50.00%) ⬆️
projects/cdk/utils/miscellaneous/is-object.ts 50.00% <50.00%> (ø)
projects/cdk/utils/miscellaneous/index.ts 100.00% <100.00%> (ø)
...cts/cdk/utils/svg/svg-linear-gradient-processor.ts 75.00% <100.00%> (+2.27%) ⬆️
projects/kit/components/avatar/avatar.component.ts 95.83% <100.00%> (+3.83%) ⬆️
.../kit/components/input-date/input-date.component.ts 83.33% <0.00%> (-1.09%) ⬇️
projects/cdk/date-time/month.ts 100.00% <0.00%> (ø)
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode force-pushed the splincode/feat/issues/3185 branch from b4a59ed to 990335b Compare January 19, 2023 08:39
@splincode
Copy link
Member Author

@vladimirpotekhin updated

@splincode splincode merged commit c4e82fa into main Jan 19, 2023
@splincode splincode deleted the splincode/feat/issues/3185 branch January 19, 2023 09:15
@well-done-bot
Copy link

well-done-bot bot commented Jan 19, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🤖 - replace typeof etc === 'string' to tuiIsString(etc) by ESlint
4 participants