Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): Tabs can't detect active tab during SSR #3395

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov commented Jan 10, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #3393

SSR returns:
before

What is the new behavior?

SSR returns:
after

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jan 10, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Jan 10, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
332.29KB (+16B 0%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
205.04KB +10%
demo/browser/runtime.(hash).js
34.69KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

Total files change +16B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.21MB (+16B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 07ba980):

https://taiga-ui--pr3395-tabs-detect-active-t-lf86cepb.web.app

(expires Wed, 11 Jan 2023 13:29:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 61.33% // Head: 61.32% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (07ba980) compared to base (16747a7).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3395      +/-   ##
==========================================
- Coverage   61.33%   61.32%   -0.01%     
==========================================
  Files        1535     1535              
  Lines       18154    18155       +1     
  Branches     2540     2540              
==========================================
  Hits        11134    11134              
- Misses       6554     6555       +1     
  Partials      466      466              
Flag Coverage Δ
addon-charts 72.46% <ø> (ø)
addon-doc 50.00% <ø> (ø)
addon-editor 50.34% <ø> (ø)
addon-mobile 62.31% <ø> (ø)
addon-table 60.79% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk 39.90% <ø> (ø)
core 76.84% <100.00%> (ø)
kit 73.01% <0.00%> (-0.02%) ⬇️
summary 61.32% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/kit/components/tabs/tabs.directive.ts 18.18% <0.00%> (-0.87%) ⬇️
...ojects/core/services/router-link-active.service.ts 70.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

const index = this.tabs.findIndex(tab => tab === element);

event.stopPropagation();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nsbarsukov nsbarsukov merged commit cbc96ae into main Jan 11, 2023
@nsbarsukov nsbarsukov deleted the tabs-detect-active-tab-ssr branch January 11, 2023 08:00
@well-done-bot
Copy link

well-done-bot bot commented Jan 11, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - Tabs can't detect active tab during SSR
3 participants