-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kit): Tabs
can't detect active tab during SSR
#3395
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
BundleMonFiles updated (1)
Unchanged files (4)
Total files change +16B 0% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Visit the preview URL for this PR (updated for commit 07ba980): https://taiga-ui--pr3395-tabs-detect-active-t-lf86cepb.web.app (expires Wed, 11 Jan 2023 13:29:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
Codecov ReportBase: 61.33% // Head: 61.32% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3395 +/- ##
==========================================
- Coverage 61.33% 61.32% -0.01%
==========================================
Files 1535 1535
Lines 18154 18155 +1
Branches 2540 2540
==========================================
Hits 11134 11134
- Misses 6554 6555 +1
Partials 466 466
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
const index = this.tabs.findIndex(tab => tab === element); | ||
|
||
event.stopPropagation(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #3393
SSR returns:
What is the new behavior?
SSR returns:
Does this PR introduce a breaking change?