Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addon-mobile): improve typing for tuiRipple #3379

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #3373

image

What is the new behavior?

image

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jan 9, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Base: 61.33% // Head: 56.39% // Decreases project coverage by -4.93% ⚠️

Coverage data is based on head (94ead51) compared to base (0b5d8bb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3379      +/-   ##
==========================================
- Coverage   61.33%   56.39%   -4.94%     
==========================================
  Files        1535      143    -1392     
  Lines       18154     1711   -16443     
  Branches     2540      169    -2371     
==========================================
- Hits        11134      965   -10169     
+ Misses       6554      707    -5847     
+ Partials      466       39     -427     
Flag Coverage Δ
addon-charts ∅ <ø> (∅)
addon-doc 50.00% <ø> (ø)
addon-editor ∅ <ø> (∅)
addon-mobile 62.31% <ø> (ø)
addon-table ∅ <ø> (∅)
addon-tablebars ∅ <ø> (∅)
cdk ∅ <ø> (∅)
core ∅ <ø> (∅)
kit ∅ <ø> (∅)
summary 56.39% <ø> (-4.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...addon-mobile/directives/ripple/ripple.directive.ts 61.90% <ø> (ø)
projects/cdk/constants/unicode-chars.ts
...rojects/addon-charts/components/arc-chart/index.ts
...ts/cdk/schematics/ng-update/steps/remove-module.ts
...g-update/v3/tests/schematic-replace-styles.spec.ts
.../directives/repeat-times/repeat-times.directive.ts
projects/cdk/utils/dom/get-actual-target.ts
projects/cdk/utils/focus/blur-native-focused.ts
...ojects/kit/components/push/push-alert.component.ts
...rojects/addon-charts/components/pie-chart/index.ts
... and 1383 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bundlemon
Copy link

bundlemon bot commented Jan 9, 2023

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
332.48KB +10%
demo/browser/vendor.(hash).js
205.04KB +10%
demo/browser/runtime.(hash).js
34.91KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.21MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

Visit the preview URL for this PR (updated for commit 94ead51):

https://taiga-ui--pr3379-splincode-feat-rippl-toloa9ad.web.app

(expires Tue, 10 Jan 2023 06:23:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@splincode splincode merged commit 0d9197e into main Jan 9, 2023
@splincode splincode deleted the splincode/feat/ripple branch January 9, 2023 07:55
@well-done-bot
Copy link

well-done-bot bot commented Jan 9, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

📚 - tuiRipple requires value
3 participants