-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): create prefer-inject-decorator #2688
feat(eslint-plugin): create prefer-inject-decorator #2688
Conversation
Hey! I tried not to hardcode a lot but in some cases we can't escape this. Anyway, there are some questions:
|
@ddubrava thanks for your contribution! 🚀
I really want to use Typescript too.
Of course, we love testing ! And we will really appreciate if you add them!
Yep, you can install it. |
We need use
As dependency |
Codecov Report
@@ Coverage Diff @@
## main #2688 +/- ##
=======================================
Coverage 56.68% 56.68%
=======================================
Files 955 955
Lines 9233 9233
Branches 1894 1894
=======================================
Hits 5234 5234
Misses 3588 3588
Partials 411 411
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@ddubrava |
…#2688) * feat(eslint-plugin): create prefer-inject-decorator * fix(): fix prefer-inject-decorator errors
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #2662
What is the new behavior?
ESLint forces to use Inject() for Dependency Injection.
Does this PR introduce a breaking change?