Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): prevent injection conflict with CSS global interface #2508

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #2474

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Aug 29, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2022

Visit the preview URL for this PR (updated for commit 9e79144):

https://taiga-ui--pr2508-splincode-fix-issues-oca889as.web.app

(expires Tue, 30 Aug 2022 18:55:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #2508 (5f410b8) into main (6bac921) will decrease coverage by 19.07%.
The diff coverage is n/a.

❗ Current head 5f410b8 differs from pull request most recent head 9e79144. Consider uploading reports for the commit 9e79144 to get more accurate results

@@             Coverage Diff             @@
##             main    #2508       +/-   ##
===========================================
- Coverage   59.06%   39.99%   -19.08%     
===========================================
  Files        1046      250      -796     
  Lines       11494     2863     -8631     
  Branches     2195      497     -1698     
===========================================
- Hits         6789     1145     -5644     
+ Misses       4226     1655     -2571     
+ Partials      479       63      -416     
Flag Coverage Δ
addon-charts 75.18% <ø> (ø)
addon-doc 27.59% <ø> (ø)
addon-editor 28.16% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 79.59% <ø> (ø)
addon-tablebars ?
cdk ?
core ?
kit ?
summary 39.99% <ø> (-19.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/core/components/scrollbar/scrollbar.component.ts
.../kit/components/input-date/input-date.directive.ts
...mponents/hosted-dropdown/hosted-dropdown.module.ts
projects/kit/enums/marker-icon-mode.ts
...iscellaneous/get-original-array-from-query-list.ts
...it/components/input-range/input-range.component.ts
projects/core/constants/decimal-symbols.ts
.../components/tree/components/tree/tree.component.ts
...cts/kit/components/pdf-viewer/pdf-viewer.module.ts
projects/kit/components/toggle/toggle.component.ts
... and 786 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@splincode splincode force-pushed the splincode/fix/issues/2474 branch from 5f410b8 to 9e79144 Compare August 29, 2022 18:50
@splincode splincode requested a review from waterplea August 30, 2022 08:01
@splincode splincode merged commit 60bd130 into main Aug 30, 2022
@splincode splincode deleted the splincode/fix/issues/2474 branch August 30, 2022 08:08
@well-done-bot
Copy link

well-done-bot bot commented Aug 30, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - Integration Tests failing
4 participants