Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit)!: Action better customization + new API #2505

Merged
merged 5 commits into from
Aug 29, 2022
Merged

Conversation

nsbarsukov
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #UIKIT-5977

Does this PR introduce a breaking change?

  • Yes
  • No

@nsbarsukov nsbarsukov self-assigned this Aug 29, 2022
@lumberjack-bot
Copy link

lumberjack-bot bot commented Aug 29, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2022

Visit the preview URL for this PR (updated for commit 01a8847):

https://taiga-ui--pr2505-action-refactor-aa9i5rl1.web.app

(expires Tue, 30 Aug 2022 16:12:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #2505 (01a8847) into v3.x (24cc17b) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v3.x    #2505   +/-   ##
=======================================
  Coverage   56.64%   56.65%           
=======================================
  Files         958      955    -3     
  Lines        9199     9184   -15     
  Branches     1885     1881    -4     
=======================================
- Hits         5211     5203    -8     
+ Misses       3582     3578    -4     
+ Partials      406      403    -3     
Flag Coverage Δ
addon-charts 73.64% <ø> (ø)
addon-doc 19.16% <ø> (ø)
addon-editor 28.82% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 83.78% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 62.94% <ø> (ø)
core 62.88% <ø> (+0.07%) ⬆️
kit 61.46% <ø> (ø)
summary 56.65% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/kit/components/action/action.component.ts 18.18% <ø> (ø)
projects/core/directives/hint/hint.component.ts 51.72% <0.00%> (-0.13%) ⬇️
projects/core/directives/hint/hint.module.ts 100.00% <0.00%> (ø)
projects/kit/components/action/action.module.ts 100.00% <0.00%> (ø)
...jects/core/directives/hint/hint-hover.directive.ts 90.00% <0.00%> (ø)
...jects/kit/components/text-area/text-area.module.ts 100.00% <0.00%> (ø)
.../addon-editor/components/toolbar/toolbar.module.ts 100.00% <0.00%> (ø)
...on-charts/components/bar-chart/bar-chart.module.ts 100.00% <0.00%> (ø)
...ditor/components/toolbar-tools/code/code.module.ts 100.00% <0.00%> (ø)
...components/color-selector/color-selector.module.ts 100.00% <0.00%> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nsbarsukov nsbarsukov changed the title [WIP] feat(kit)!: Action better customization + new API feat(kit)!: Action better customization + new API Aug 29, 2022
@nsbarsukov nsbarsukov marked this pull request as ready for review August 29, 2022 14:39
Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove code block, plain text here would look better, I think:
image

@@ -175,4 +175,19 @@
width: ~'calc(100% + 2.375rem);'; // margin compensation
margin: @padding-large calc(-1.25rem + 1px) calc(-1.25rem + 1px); // 1px is compensations of border
}

/* Artificially increased specificity */
&__marker&__marker {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this all of a sudden? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can instead leave those styles inside action.style.less? Since they are Action related, not Island related?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done ✅

@waterplea
Copy link
Collaborator

Also let's add notification This component requires @taiga-ui/styles optional package with '@taiga-ui/styles/taiga-ui-global' added to your global styles here and on Island component.

@nsbarsukov
Copy link
Member Author

Also let's add notification This component requires @taiga-ui/styles optional package with '@taiga-ui/styles/taiga-ui-global' added to your global styles here and on Island component.

@waterplea waterplea merged commit 7a616fb into v3.x Aug 29, 2022
@waterplea waterplea deleted the action-refactor branch August 29, 2022 16:46
@well-done-bot
Copy link

well-done-bot bot commented Aug 29, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants