-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kit)!: Action
better customization + new API
#2505
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Visit the preview URL for this PR (updated for commit 01a8847): https://taiga-ui--pr2505-action-refactor-aa9i5rl1.web.app (expires Tue, 30 Aug 2022 16:12:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
6649fdb
to
eb657c5
Compare
eb657c5
to
70a0a9f
Compare
Codecov Report
@@ Coverage Diff @@
## v3.x #2505 +/- ##
=======================================
Coverage 56.64% 56.65%
=======================================
Files 958 955 -3
Lines 9199 9184 -15
Branches 1885 1881 -4
=======================================
- Hits 5211 5203 -8
+ Misses 3582 3578 -4
+ Partials 406 403 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Action
better customization + new APIAction
better customization + new API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -175,4 +175,19 @@ | |||
width: ~'calc(100% + 2.375rem);'; // margin compensation | |||
margin: @padding-large calc(-1.25rem + 1px) calc(-1.25rem + 1px); // 1px is compensations of border | |||
} | |||
|
|||
/* Artificially increased specificity */ | |||
&__marker&__marker { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this all of a sudden? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, we can't override these lines :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can instead leave those styles inside action.style.less
? Since they are Action
related, not Island
related?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done ✅
Also let's add notification |
✅ |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #UIKIT-5977
Does this PR introduce a breaking change?