Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk)!: the tuiLet directive can possibility emit of null #2496

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

@lumberjack-bot
Copy link

lumberjack-bot bot commented Aug 28, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2022

Visit the preview URL for this PR (updated for commit 29c4b8a):

https://taiga-ui--pr2496-splincode-fix-let-yi5lwzyq.web.app

(expires Tue, 30 Aug 2022 15:58:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

❗ No coverage uploaded for pull request base (v3.x@9b05094). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head a74f990 differs from pull request most recent head 29c4b8a. Consider uploading reports for the commit 29c4b8a to get more accurate results

@@           Coverage Diff           @@
##             v3.x    #2496   +/-   ##
=======================================
  Coverage        ?   56.64%           
=======================================
  Files           ?      958           
  Lines           ?     9199           
  Branches        ?     1885           
=======================================
  Hits            ?     5211           
  Misses          ?     3582           
  Partials        ?      406           
Flag Coverage Δ
addon-charts 73.64% <0.00%> (?)
addon-doc 19.16% <0.00%> (?)
addon-editor 28.82% <0.00%> (?)
addon-mobile ∅ <0.00%> (?)
addon-table 83.78% <0.00%> (?)
addon-tablebars ∅ <0.00%> (?)
cdk 62.94% <0.00%> (?)
core 62.81% <0.00%> (?)
kit 61.46% <0.00%> (?)
summary 56.64% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tinkoff-bot tinkoff-bot force-pushed the splincode/fix/let branch 5 times, most recently from ad1fe21 to 04d2345 Compare August 29, 2022 13:28
@waterplea waterplea merged commit 8424626 into v3.x Aug 29, 2022
@waterplea waterplea deleted the splincode/fix/let branch August 29, 2022 16:43
@well-done-bot
Copy link

well-done-bot bot commented Aug 29, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants