-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core)!: Dropdown
refactor dropdowns completely
#2389
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Visit the preview URL for this PR (updated for commit cb8af65): https://taiga-ui--pr2389-dropdowns-gm4ghx0v.web.app (expires Tue, 23 Aug 2022 10:17:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
https://taiga-ui--pr2389-dropdowns-wbsh8ugo.web.app/components/data-list |
new behavior of this example: Is it expected ? Before => After: before.after.mov |
We had different default alignments in dropdown controller and in abstract dropdown directive. I changed it all to left by default. Here we need to override it to right, I'll update it. |
accdbfc
to
71a6e7b
Compare
projects/addon-editor/components/toolbar/toolbar-navigation-manager.directive.ts
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## v3.x #2389 +/- ##
=======================================
Coverage ? 56.60%
=======================================
Files ? 955
Lines ? 9291
Branches ? 1895
=======================================
Hits ? 5259
Misses ? 3630
Partials ? 402
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
projects/core/components/hosted-dropdown/hosted-dropdown.template.html
Outdated
Show resolved
Hide resolved
projects/core/components/hosted-dropdown/test/hosted-dropdown.component.spec.ts
Show resolved
Hide resolved
projects/core/directives/dropdown/dropdown-position-sided.directive.ts
Outdated
Show resolved
Hide resolved
projects/core/directives/dropdown/dropdown-position.directive.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to check why E2E tests are failed
chore: fix build chore: add `DropdownHover` chore: fix build chore: fix demo chore: fix issues chore: fix tests chore: fix comments chore: fix demo
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
What is the new behavior?
Does this PR introduce a breaking change?