Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core)!: Dropdown refactor dropdowns completely #2389

Merged
merged 5 commits into from
Aug 22, 2022
Merged

Conversation

waterplea
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Aug 16, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2022

Visit the preview URL for this PR (updated for commit cb8af65):

https://taiga-ui--pr2389-dropdowns-gm4ghx0v.web.app

(expires Tue, 23 Aug 2022 10:17:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@splincode
Copy link
Member

@nsbarsukov
Copy link
Member

new behavior of this example:
https://taiga-ui.dev/components/hosted-dropdown#native

Is it expected ?

Before => After:

before.after.mov

@waterplea
Copy link
Collaborator Author

new behavior of this example: https://taiga-ui.dev/components/hosted-dropdown#native

Is it expected ?

Before => After:

before.after.mov

We had different default alignments in dropdown controller and in abstract dropdown directive. I changed it all to left by default. Here we need to override it to right, I'll update it.

@tinkoff-bot tinkoff-bot force-pushed the dropdowns branch 2 times, most recently from accdbfc to 71a6e7b Compare August 18, 2022 08:55
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

❗ No coverage uploaded for pull request base (v3.x@03a198d). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v3.x    #2389   +/-   ##
=======================================
  Coverage        ?   56.60%           
=======================================
  Files           ?      955           
  Lines           ?     9291           
  Branches        ?     1895           
=======================================
  Hits            ?     5259           
  Misses          ?     3630           
  Partials        ?      402           
Flag Coverage Δ
addon-charts 74.50% <0.00%> (?)
addon-doc 19.16% <0.00%> (?)
addon-editor 27.75% <0.00%> (?)
addon-mobile ∅ <0.00%> (?)
addon-table 83.78% <0.00%> (?)
addon-tablebars ∅ <0.00%> (?)
cdk 64.01% <0.00%> (?)
core 63.21% <0.00%> (?)
kit 61.28% <0.00%> (?)
summary 56.60% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@splincode splincode self-requested a review August 19, 2022 15:49
Copy link
Member

@splincode splincode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to check why E2E tests are failed

@splincode splincode self-requested a review August 19, 2022 22:04
chore: fix build

chore: add `DropdownHover`

chore: fix build

chore: fix demo

chore: fix issues

chore: fix tests

chore: fix comments

chore: fix demo
@waterplea waterplea merged commit 0a81fbf into v3.x Aug 22, 2022
@waterplea waterplea deleted the dropdowns branch August 22, 2022 11:03
@well-done-bot
Copy link

well-done-bot bot commented Aug 22, 2022

'Well done'

This was referenced Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants