Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core)!: tuiFormatNumber(value, configs) new function signature #2309

Merged
merged 4 commits into from
Aug 9, 2022

Conversation

nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov commented Aug 8, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Utility:

function tuiFormatNumber(
    value: number,
    decimalLimit: number | null = null,
    decimalSeparator: string = `,`,
    thousandSeparator: string = CHAR_NO_BREAK_SPACE,
    zeroPadding: boolean = true,
): string;

Pipe:

<p>Formatted number: {{ 10500.33 | tuiFormatNumber: 4:'.' }}</p>

What is the new behavior?

Utility:

function tuiFormatNumber(
    value: number,
    {
        decimalLimit = null,
        decimalSeparator = `,`,
        thousandSeparator = CHAR_NO_BREAK_SPACE,
        zeroPadding = true,
    }: Partial<TuiNumberFormatSettings> = {},
): string

Pipe:

<p>Formatted number: {{ 10500.33 | tuiFormatNumber: {decimalLimit: 4, decimalSeparator: '.'} }}</p>

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Aug 8, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

❗ No coverage uploaded for pull request base (v3.x@e156c21). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v3.x    #2309   +/-   ##
=======================================
  Coverage        ?   56.34%           
=======================================
  Files           ?      973           
  Lines           ?     9566           
  Branches        ?     1937           
=======================================
  Hits            ?     5390           
  Misses          ?     3747           
  Partials        ?      429           
Flag Coverage Δ
addon-charts 73.88% <0.00%> (?)
addon-doc 19.12% <0.00%> (?)
addon-editor 27.89% <0.00%> (?)
addon-mobile ∅ <0.00%> (?)
addon-table 83.78% <0.00%> (?)
addon-tablebars ∅ <0.00%> (?)
cdk 63.84% <0.00%> (?)
core 68.39% <0.00%> (?)
kit 57.86% <0.00%> (?)
summary 56.34% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

Visit the preview URL for this PR (updated for commit 7f5f864):

https://taiga-ui--pr2309-format-number-fn-arg-hrufd4o7.web.app

(expires Wed, 10 Aug 2022 12:17:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@tinkoff-bot tinkoff-bot force-pushed the format-number-fn-args branch 2 times, most recently from 1918350 to b4f6e49 Compare August 8, 2022 15:31
@tinkoff-bot tinkoff-bot force-pushed the format-number-fn-args branch from 4c0bbaa to 7f5f864 Compare August 9, 2022 12:12
@nsbarsukov nsbarsukov merged commit d5277c2 into v3.x Aug 9, 2022
@nsbarsukov nsbarsukov deleted the format-number-fn-args branch August 9, 2022 12:48
@well-done-bot
Copy link

well-done-bot bot commented Aug 9, 2022

'Well done'

splincode pushed a commit that referenced this pull request Aug 9, 2022
…ture (#2309)

* refactor(core)!: `tuiFormatNumber(value, configs)` new function signature

* refactor(core)!: `TuiNumberFormatSettings` add `decimalLimit`

* refactor(core)!: `FormatNumberPipe` replace all optional arguments with single object

* feat(core): new constant `TUI_DEFAULT_NUMBER_FORMAT`
tinkoff-bot pushed a commit that referenced this pull request Aug 9, 2022
…ture (#2309)

* refactor(core)!: `tuiFormatNumber(value, configs)` new function signature

* refactor(core)!: `TuiNumberFormatSettings` add `decimalLimit`

* refactor(core)!: `FormatNumberPipe` replace all optional arguments with single object

* feat(core): new constant `TUI_DEFAULT_NUMBER_FORMAT`
splincode pushed a commit that referenced this pull request Aug 10, 2022
…ture (#2309)

* refactor(core)!: `tuiFormatNumber(value, configs)` new function signature

* refactor(core)!: `TuiNumberFormatSettings` add `decimalLimit`

* refactor(core)!: `FormatNumberPipe` replace all optional arguments with single object

* feat(core): new constant `TUI_DEFAULT_NUMBER_FORMAT`
splincode pushed a commit that referenced this pull request Aug 16, 2022
…ture (#2309)

* refactor(core)!: `tuiFormatNumber(value, configs)` new function signature

* refactor(core)!: `TuiNumberFormatSettings` add `decimalLimit`

* refactor(core)!: `FormatNumberPipe` replace all optional arguments with single object

* feat(core): new constant `TUI_DEFAULT_NUMBER_FORMAT`
splincode pushed a commit that referenced this pull request Aug 16, 2022
…ture (#2309)

* refactor(core)!: `tuiFormatNumber(value, configs)` new function signature

* refactor(core)!: `TuiNumberFormatSettings` add `decimalLimit`

* refactor(core)!: `FormatNumberPipe` replace all optional arguments with single object

* feat(core): new constant `TUI_DEFAULT_NUMBER_FORMAT`
splincode pushed a commit that referenced this pull request Aug 22, 2022
…ture (#2309)

* refactor(core)!: `tuiFormatNumber(value, configs)` new function signature

* refactor(core)!: `TuiNumberFormatSettings` add `decimalLimit`

* refactor(core)!: `FormatNumberPipe` replace all optional arguments with single object

* feat(core): new constant `TUI_DEFAULT_NUMBER_FORMAT`
splincode pushed a commit that referenced this pull request Aug 23, 2022
…ture (#2309)

* refactor(core)!: `tuiFormatNumber(value, configs)` new function signature

* refactor(core)!: `TuiNumberFormatSettings` add `decimalLimit`

* refactor(core)!: `FormatNumberPipe` replace all optional arguments with single object

* feat(core): new constant `TUI_DEFAULT_NUMBER_FORMAT`
tinkoff-bot pushed a commit that referenced this pull request Aug 23, 2022
…ture (#2309)

* refactor(core)!: `tuiFormatNumber(value, configs)` new function signature

* refactor(core)!: `TuiNumberFormatSettings` add `decimalLimit`

* refactor(core)!: `FormatNumberPipe` replace all optional arguments with single object

* feat(core): new constant `TUI_DEFAULT_NUMBER_FORMAT`
tinkoff-bot pushed a commit that referenced this pull request Aug 23, 2022
…ture (#2309)

* refactor(core)!: `tuiFormatNumber(value, configs)` new function signature

* refactor(core)!: `TuiNumberFormatSettings` add `decimalLimit`

* refactor(core)!: `FormatNumberPipe` replace all optional arguments with single object

* feat(core): new constant `TUI_DEFAULT_NUMBER_FORMAT`
tinkoff-bot pushed a commit that referenced this pull request Aug 23, 2022
…ture (#2309)

* refactor(core)!: `tuiFormatNumber(value, configs)` new function signature

* refactor(core)!: `TuiNumberFormatSettings` add `decimalLimit`

* refactor(core)!: `FormatNumberPipe` replace all optional arguments with single object

* feat(core): new constant `TUI_DEFAULT_NUMBER_FORMAT`
splincode pushed a commit that referenced this pull request Aug 24, 2022
…ture (#2309)

* refactor(core)!: `tuiFormatNumber(value, configs)` new function signature

* refactor(core)!: `TuiNumberFormatSettings` add `decimalLimit`

* refactor(core)!: `FormatNumberPipe` replace all optional arguments with single object

* feat(core): new constant `TUI_DEFAULT_NUMBER_FORMAT`
tinkoff-bot pushed a commit that referenced this pull request Aug 24, 2022
…ture (#2309)

* refactor(core)!: `tuiFormatNumber(value, configs)` new function signature

* refactor(core)!: `TuiNumberFormatSettings` add `decimalLimit`

* refactor(core)!: `FormatNumberPipe` replace all optional arguments with single object

* feat(core): new constant `TUI_DEFAULT_NUMBER_FORMAT`
splincode pushed a commit that referenced this pull request Aug 25, 2022
…ture (#2309)

* refactor(core)!: `tuiFormatNumber(value, configs)` new function signature

* refactor(core)!: `TuiNumberFormatSettings` add `decimalLimit`

* refactor(core)!: `FormatNumberPipe` replace all optional arguments with single object

* feat(core): new constant `TUI_DEFAULT_NUMBER_FORMAT`
splincode pushed a commit that referenced this pull request Aug 25, 2022
…ture (#2309)

* refactor(core)!: `tuiFormatNumber(value, configs)` new function signature

* refactor(core)!: `TuiNumberFormatSettings` add `decimalLimit`

* refactor(core)!: `FormatNumberPipe` replace all optional arguments with single object

* feat(core): new constant `TUI_DEFAULT_NUMBER_FORMAT`
splincode pushed a commit that referenced this pull request Aug 26, 2022
…ture (#2309)

* refactor(core)!: `tuiFormatNumber(value, configs)` new function signature

* refactor(core)!: `TuiNumberFormatSettings` add `decimalLimit`

* refactor(core)!: `FormatNumberPipe` replace all optional arguments with single object

* feat(core): new constant `TUI_DEFAULT_NUMBER_FORMAT`
splincode pushed a commit that referenced this pull request Aug 30, 2022
…ture (#2309)

* refactor(core)!: `tuiFormatNumber(value, configs)` new function signature

* refactor(core)!: `TuiNumberFormatSettings` add `decimalLimit`

* refactor(core)!: `FormatNumberPipe` replace all optional arguments with single object

* feat(core): new constant `TUI_DEFAULT_NUMBER_FORMAT`
This was referenced Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants